fix(config): tsconfig should support other formats too

Author: sumitarora

packages/@ngtools/webpack/src/plugin.ts

@@ -103,7 +103,7 @@ export class AotPlugin implements Tapable {
 
  let tsConfigJson: any = null;
  try {
- tsConfigJson = JSON.parse(fs.readFileSync(this._tsConfigPath, 'utf8'));
+ tsConfigJson = JSON.parse(ts.sys.readFile(this._tsConfigPath));
  } catch (err) {
  throw new Error(`An error happened while parsing ${this._tsConfigPath} JSON: ${err}.`);
  }

tests/e2e/tests/misc/different-file-format.ts

@@ -0,0 +1,44 @@
+import {ng} from '../../utils/process';
+import * as fs from '../../utils/fs';
+import {getGlobalVariable} from '../../utils/env';
+import {expectGitToBeClean} from '../../utils/git';
+import {join} from 'path';
+
+const tsconfig = `{
+ "compilerOptions": {
+ "baseUrl": "",
+ "declaration": false,
+ "emitDecoratorMetadata": true,
+ "experimentalDecorators": true,
+ "lib": [
+ "es2016",
+ "dom"
+ ],
+ "mapRoot": "./",
+ "module": "es2015",
+ "moduleResolution": "node",
+ "outDir": "../dist/out-tsc",
+ "sourceMap": true,
+ "target": "es5",
+ "typeRoots": [
+ "../node_modules/@types"
+ ]
+ }
+}`;
+
+const options = {
+ encoding: 'utf8'
+};
+
+export default function() {
+ return Promise.resolve()
+ .then(() => process.chdir(getGlobalVariable('tmp-root')))
+ .then(() => ng('new', 'foo'))
+ .then(() => fs.expectFileToExist(join(process.cwd(), 'foo')))
+ .then(() => process.chdir('./foo'))
+ .then(() => fs.deleteFile('./src/tsconfig.json'))
+ .then(() => fs.writeFile('./src/tsconfig.json', '\ufeff' + tsconfig, options))
+ .then(() => ng('build', '--env=dev'))
+ .then(() => fs.expectFileToMatch('dist/index.html', 'main.bundle.js'))
+ .then(() => expectGitToBeClean());
+}

tests/e2e/utils/fs.ts

@@ -15,9 +15,9 @@ export function readFile(fileName: string) {
  });
 }
 
-export function writeFile(fileName: string, content: string) {
+export function writeFile(fileName: string, content: string, options?: any) {
  return new Promise<void>((resolve, reject) => {
- fs.writeFile(fileName, content, (err: any) => {
+ fs.writeFile(fileName, content, options, (err: any) => {
  if (err) {
  reject(err);
  } else {