Merge pull request #588 from JoseAlcerreca/warningsAsErrors

[All] Restricts allWarningsAsErrors to CI and local properties.

Author: JoseAlcerreca

.github/ci-gradle.properties

@@ -21,3 +21,6 @@ org.gradle.workers.max=2
 
 kotlin.incremental=false
 kotlin.compiler.execution.strategy=in-process
+
+# Controls KotlinOptions.allWarningsAsErrors. This is used in CI and can be set in local properties.
+warningsAsErrors=true

Crane/build.gradle

@@ -60,8 +60,8 @@ subprojects {
 
  tasks.withType(org.jetbrains.kotlin.gradle.tasks.KotlinCompile).configureEach {
  kotlinOptions {
- // Treat all Kotlin warnings as errors
- allWarningsAsErrors = true
+ // Treat all Kotlin warnings as errors (disabled by default)
+ allWarningsAsErrors = project.hasProperty("warningsAsErrors") ? project.warningsAsErrors : false
 
  jvmTarget = "1.8"
 

JetNews/app/build.gradle

@@ -57,11 +57,6 @@ android {
  targetCompatibility JavaVersion.VERSION_1_8
  }
 
- kotlinOptions {
- jvmTarget = '1.8'
- allWarningsAsErrors = true
- }
-
  buildFeatures {
  compose true
  }
@@ -115,8 +110,9 @@ dependencies {
 
 tasks.withType(org.jetbrains.kotlin.gradle.tasks.KotlinCompile).configureEach {
  kotlinOptions {
- // Treat all Kotlin warnings as errors
- allWarningsAsErrors = true
+ // Treat all Kotlin warnings as errors (disabled by default)
+ allWarningsAsErrors = project.hasProperty("warningsAsErrors") ? project.warningsAsErrors : false
+
  freeCompilerArgs += '-Xopt-in=kotlin.RequiresOptIn'
  // Enable experimental coroutines APIs, including Flow
  freeCompilerArgs += '-Xopt-in=kotlin.Experimental'

Jetcaster/build.gradle

@@ -61,8 +61,8 @@ subprojects {
 
  tasks.withType(org.jetbrains.kotlin.gradle.tasks.KotlinCompile).configureEach {
  kotlinOptions {
- // Treat all Kotlin warnings as errors
- allWarningsAsErrors = true
+ // Treat all Kotlin warnings as errors (disabled by default)
+ allWarningsAsErrors = project.hasProperty("warningsAsErrors") ? project.warningsAsErrors : false
 
  freeCompilerArgs += '-Xopt-in=kotlin.RequiresOptIn'
 

Jetchat/build.gradle

@@ -61,8 +61,8 @@ subprojects {
 
  tasks.withType(org.jetbrains.kotlin.gradle.tasks.KotlinCompile).configureEach {
  kotlinOptions {
- // Treat all Kotlin warnings as errors
- allWarningsAsErrors = true
+ // Treat all Kotlin warnings as errors (disabled by default)
+ allWarningsAsErrors = project.hasProperty("warningsAsErrors") ? project.warningsAsErrors : false
 
  freeCompilerArgs += '-Xopt-in=kotlin.RequiresOptIn'
 

Jetsnack/build.gradle

@@ -47,12 +47,15 @@ subprojects {
 
  tasks.withType(org.jetbrains.kotlin.gradle.tasks.KotlinCompile).configureEach {
  kotlinOptions {
- jvmTarget = '1.8'
- allWarningsAsErrors = true
- // Opt-in to experimental compose APIs
+ // Treat all Kotlin warnings as errors (disabled by default)
+ allWarningsAsErrors = project.hasProperty("warningsAsErrors") ? project.warningsAsErrors : false
+
  freeCompilerArgs += '-Xopt-in=kotlin.RequiresOptIn'
- // Enable experimental coroutines APIs, including collectAsState()
- freeCompilerArgs += '-Xopt-in=kotlinx.coroutines.ExperimentalCoroutinesApi'
+ // Enable experimental coroutines APIs, including Flow
+ freeCompilerArgs += '-Xopt-in=kotlin.Experimental'
+
+ // Set JVM target to 1.8
+ jvmTarget = "1.8"
  }
  }
 

Jetsurvey/build.gradle

@@ -59,8 +59,8 @@ subprojects {
 
  tasks.withType(org.jetbrains.kotlin.gradle.tasks.KotlinCompile).configureEach {
  kotlinOptions {
- // Treat all Kotlin warnings as errors
- allWarningsAsErrors = true
+ // Treat all Kotlin warnings as errors (disabled by default)
+ allWarningsAsErrors = project.hasProperty("warningsAsErrors") ? project.warningsAsErrors : false
 
  freeCompilerArgs += '-Xopt-in=kotlin.RequiresOptIn'
 

Owl/build.gradle

@@ -47,10 +47,12 @@ subprojects {
 
  tasks.withType(org.jetbrains.kotlin.gradle.tasks.KotlinCompile).configureEach {
  kotlinOptions {
- jvmTarget = '1.8'
- allWarningsAsErrors = true
+ // Treat all Kotlin warnings as errors (disabled by default)
+ allWarningsAsErrors = project.hasProperty("warningsAsErrors") ? project.warningsAsErrors : false
  // Opt-in to experimental compose APIs
  freeCompilerArgs += '-Xopt-in=kotlin.RequiresOptIn'
+
+ jvmTarget = '1.8'
  }
  }