Merge pull request magento#94 from magento-commerce/imported-loginesta-magento-coding-standard-308

[Imported] AC-1167 Add all filesystem PHP native functions covered by Filesystem\DriverInterface to DiscouragedFunctionSniff

Author: loginesta

Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php

@@ -229,5 +229,14 @@ class DiscouragedFunctionSniff extends ForbiddenFunctionsSniff
  '^strval$' => '(string) construction',
  '^htmlspecialchars$' => '\Magento\Framework\Escaper->escapeHtml',
  '^getimagesize$' => 'getimagesizefromstring',
+ '^file_exists$' => 'Magento\Framework\Filesystem\DriverInterface::isExists()',
+ '^file_get_contents$' => 'Magento\Framework\Filesystem\DriverInterface::fileGetContents()',
+ '^file_put_contents$' => 'Magento\Framework\Filesystem\DriverInterface::filePutContents()',
+ '^fgetcsv$' => 'Magento\Framework\Filesystem\DriverInterface::fileGetCsv()',
+ '^fputcsv$' => 'Magento\Framework\Filesystem\DriverInterface::filePutCsv()',
+ '^ftell$' => 'Magento\Framework\Filesystem\DriverInterface::fileTell()',
+ '^fseek$' => 'Magento\Framework\Filesystem\DriverInterface::fileSeek()',
+ '^feof$' => 'Magento\Framework\Filesystem\DriverInterface::endOfFile()',
+ '^flock$' => 'Magento\Framework\Filesystem\DriverInterface::fileLock()',
  ];
 }

Magento2/Tests/Functions/DiscouragedFunctionUnitTest.inc

@@ -464,3 +464,21 @@ $str = chop($text, 'ttt');
 md5($text);
 
 htmlspecialchars('text');
+
+file_exists('./');
+
+file_get_contents('file.txt');
+
+file_put_contents($file, 'test');
+
+fgetcsv($fp,'r');
+
+fputcsv($fp, $fields);
+
+ftell($file);
+
+fseek($file, 0);
+
+feof($fp);
+
+flock($fp, LOCK_EX);

Magento2/Tests/Functions/DiscouragedFunctionUnitTest.php

@@ -246,7 +246,16 @@ public function getWarningList()
  458 => 1,
  460 => 1,
  462 => 1,
- 466 => 1
+ 466 => 1,
+ 468 => 1,
+ 470 => 1,
+ 472 => 1,
+ 474 => 1,
+ 476 => 1,
+ 478 => 1,
+ 480 => 1,
+ 482 => 1,
+ 484 => 1
  ];
  }
 }