fix: switched to aiohttp for more robust webrtc connectivity #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
ivelin commented Feb 13, 2020
ivelin commented - aiohttp has good asyncio support
- allows simultaneous pings back to http proxy client while waiting on http proxy request
- better http connection pooling and keepalive
- aiohttp has good asyncio support - allows simultaneous pings back to http proxy client while waiting on http proxy request - better http connection pooling and keepalive
| Hello @ivelin! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
Contributor Author
| 🎉 This PR is included in version 1.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.