feat: expose dedicated configuration #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- store config in yaml
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
| Very cool, @muka ! Would you like to add a section to README with a reference example to peerjs-config.yaml ? |
| You are right, will add the config sample in the docs |
| Merging this one so its not dangling. Let's do the docs update as a separate PR. |
ivelin pushed a commit that referenced this pull request Nov 9, 2020
# [1.4.0](v1.3.0...v1.4.0) (2020-11-09) ### Features * expose dedicated configuration ([c1cf754](c1cf754)), closes [#37](#37)
| 🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This should be good to close #34