Feat: Require comparisons to be strict (fixes #90)

Author: OndraM

ecs.php

@@ -122,6 +122,7 @@
 use PhpCsFixer\Fixer\Semicolon\NoSinglelineWhitespaceBeforeSemicolonsFixer;
 use PhpCsFixer\Fixer\Semicolon\SpaceAfterSemicolonFixer;
 use PhpCsFixer\Fixer\Strict\DeclareStrictTypesFixer;
+use PhpCsFixer\Fixer\Strict\StrictComparisonFixer;
 use PhpCsFixer\Fixer\Strict\StrictParamFixer;
 use PhpCsFixer\Fixer\StringNotation\SingleQuoteFixer;
 use PhpCsFixer\Fixer\Whitespace\BlankLineBeforeStatementFixer;
@@ -358,6 +359,8 @@
  DeclareStrictTypesFixer::class,
  // Functions should be used with `$strict` param set to `true`
  StrictParamFixer::class,
+ // Comparisons should be strict, `===` or `!==` must be used for comparisons
+ StrictComparisonFixer::class,
  // Convert double quotes to single quotes for simple strings
  SingleQuoteFixer::class,
  // Remove extra spaces in a nullable typehint

tests/Integration/Fixtures/Basic.correct.php.inc

@@ -14,8 +14,8 @@ class Basic
  $lambdaWithUnusedImport = function () { return 'foo'; };
  // NoUselessSprintfFixer
  $uselessSprintf = 'bar';
- // SingleSpaceAfterConstructFixer
- if ($a == $b) {
+ // SingleSpaceAfterConstructFixer, StrictComparisonFixer
+ if ($a === $b || $bazLength !== 3) {
  return true;
  }
 

tests/Integration/Fixtures/Basic.wrong.php.inc

@@ -13,8 +13,8 @@ class Basic
  $lambdaWithUnusedImport = function () use ($fooBar) { return 'foo'; };
  // NoUselessSprintfFixer
  $uselessSprintf = sprintf('bar');
- // SingleSpaceAfterConstructFixer
- if ($a == $b) { return true; }
+ // SingleSpaceAfterConstructFixer, StrictComparisonFixer
+ if ($a == $b || $bazLength != 3) { return true; }
  return false; // BlankLineBeforeStatementFixer
  }