Add data offset to Char array data reader

Author: alexandrnikitin

bloom-filter/src/main/scala/bloomfilter/CanGenerate128HashFrom.scala

@@ -21,7 +21,7 @@ object CanGenerate128HashFrom {
 
  override def generateHash(from: String): (Long, Long) = {
  val value = unsafe.getObject(from, valueOffset).asInstanceOf[Array[Char]]
- MurmurHash3Generic.murmurhash3_x64_128(value, 0, from.length, 0)
+ MurmurHash3Generic.murmurhash3_x64_128(value, 0, from.length * 2, 0)
  }
  }
 

bloom-filter/src/main/scala/bloomfilter/CanGenerateHashFrom.scala

@@ -25,7 +25,7 @@ object CanGenerateHashFrom {
 
  override def generateHash(from: String): Long = {
  val value = unsafe.getObject(from, valueOffset).asInstanceOf[Array[Char]]
- MurmurHash3Generic.murmurhash3_x64_64(value, 0, from.length, 0)
+ MurmurHash3Generic.murmurhash3_x64_64(value, 0, from.length * 2, 0)
  }
  }
 

bloom-filter/src/main/scala/bloomfilter/CanGetDataFrom.scala

@@ -28,13 +28,14 @@ object CanGetDataFrom {
  }
 
  implicit case object CanGetDataFromArrayChar extends CanGetDataFrom[Array[Char]] {
+ private val arrayCharOffset = unsafe.arrayBaseOffset(classOf[Array[Char]])
 
  override def getLong(from: Array[Char], offset: Int): Long = {
- unsafe.getLong(from, offset.toLong)
+ unsafe.getLong(from, arrayCharOffset + offset.toLong)
  }
 
  override def getByte(from: Array[Char], offset: Int): Byte = {
- unsafe.getByte(from, offset.toLong)
+ unsafe.getByte(from, arrayCharOffset + offset.toLong)
  }
  }
 }

tests/src/test/scala/tests/bloomfilter/CanGetDataFromSpec.scala

@@ -0,0 +1,27 @@
+package tests.bloomfilter
+
+import bloomfilter.CanGetDataFrom.CanGetDataFromArrayChar
+import org.scalatest.{FreeSpec, Matchers}
+
+class CanGetDataFromSpec extends FreeSpec with Matchers {
+ "CanGetDataFromArrayChar" in {
+ CanGetDataFromArrayChar.getByte(Array[Char]('a'), 0) shouldEqual 97.toByte
+ CanGetDataFromArrayChar.getByte(Array[Char]('a'), 1) shouldEqual 0.toByte
+
+ CanGetDataFromArrayChar.getByte(Array[Char]('a', 'b'), 0) shouldEqual 97.toByte
+ CanGetDataFromArrayChar.getByte(Array[Char]('a', 'b'), 1) shouldEqual 0.toByte
+ CanGetDataFromArrayChar.getByte(Array[Char]('a', 'b'), 2) shouldEqual 98.toByte
+ CanGetDataFromArrayChar.getByte(Array[Char]('a', 'b'), 3) shouldEqual 0.toByte
+
+ CanGetDataFromArrayChar.getLong(Array[Char]('a', 'b', 'c', 'd'), 0) shouldEqual
+ (0.toLong << 56) |
+ (('d'.toByte & 0xffL) << 48) |
+ ((0 & 0xffL) << 40) |
+ (('c'.toByte & 0xffL) << 32) |
+ ((0 & 0xffL) << 24) |
+ (('b' & 0xffL) << 16) |
+ ((0 & 0xffL) << 8) |
+ 'a' & 0xffL
+
+ }
+}