More coverage (#12)

* updates * more tests * version bump

Author: ajb413

README.md

@@ -1,7 +1,7 @@
 # PubNub Functions Mock
 
 [![Build Status](https://travis-ci.org/ajb413/pubnub-functions-mock.svg?branch=master)](https://travis-ci.org/ajb413/pubnub-functions-mock)
-[![Coverage Status](https://coveralls.io/repos/github/ajb413/pubnub-functions-mock/badge.svg?branch=master)](https://coveralls.io/github/ajb413/pubnub-functions-mock?branch=master)
+[![Coverage Status](https://coveralls.io/repos/github/ajb413/pubnub-functions-mock/badge.svg?branch=master&c=b)](https://coveralls.io/github/ajb413/pubnub-functions-mock?branch=master&c=b)
 [![Known Vulnerabilities](https://snyk.io/test/github/ajb413/pubnub-functions-mock/badge.svg)](https://snyk.io/test/github/ajb413/pubnub-functions-mock)
 
 Unit test PubNub Functions event handlers on your local machine

package.json

@@ -1,6 +1,6 @@
 {
  "name": "pubnub-functions-mock",
- "version": "0.0.11",
+ "version": "0.0.12",
  "description": "Mocks PubNub Functions modules for unit testing",
  "main": "src/index.js",
  "repository": {

src/modules/kvstore.js

@@ -39,15 +39,15 @@ const kvInterface = {
  kvInterface.keyValueCounters[key] += value || 1;
  }
 
- resolve(null);
+ resolve(kvInterface.keyValueCounters[key]);
  });
  },
  getCounter: (key) => {
  return new Promise((resolve) => {
  if (typeof(key) !== "string") {
  throw Error("not a valid key. kvstore.get expects a string.");
  }
- resolve(kvInterface.keyValueCounters[key]);
+ resolve(kvInterface.keyValueCounters[key] || 0);
  });
  },
  removeItem: (key) => {

test/endpointEventHandler.js

@@ -59,7 +59,7 @@ export default (request, response) => {
  if (request.incKvValue) {
  let key = request.key;
  let value = request.value;
- return kvstore.incrCounter(key, value, 123).then((value) => {
+ return kvstore.incrCounter(key, value).then((value) => {
  response.status = 200;
  return response.send(value);
  }).catch(testFail);

test/unit.test.js

@@ -111,7 +111,26 @@ describe('#endpoint', () => {
  });
  });
 
- it('returns a kvstore "get" value that has been mocked', function (done) {
+ it('fails to kvstore.get', function (done) {
+ 
+ let request = Object.assign({}, endpointRequestObject);
+ let response = Object.assign({}, endpointResponseObject);
+
+ request.getKvValue = true;
+ request.key = 123;
+
+ let correctResult = {
+ "status": 500 
+ };
+
+ endpoint(request, response).then((testResult) => {
+ assert.equal(testResult.status, correctResult.status, 'status');
+ })
+
+ done();
+ });
+
+ it('returns a kvstore.get value that has been mocked', function (done) {
 
  let request = Object.assign({}, endpointRequestObject);
  let response = Object.assign({}, endpointResponseObject);
@@ -297,6 +316,47 @@ describe('#endpoint', () => {
  });
  });
 
+ it('fails to kvstore.getCounter', function (done) {
+ 
+ let request = Object.assign({}, endpointRequestObject);
+ let response = Object.assign({}, endpointResponseObject);
+
+ request.getKvCounter = true;
+ request.key = 123;
+
+ let correctResult = {
+ "status": 500
+ };
+
+ endpoint(request, response).then((testResult) => {
+ assert.equal(testResult.status, correctResult.status, 'status');
+ done();
+ });
+
+ });
+
+ it('kvstore.getCounter', function (done) {
+ 
+ let request = Object.assign({}, endpointRequestObject);
+ let response = Object.assign({}, endpointResponseObject);
+
+ request.getKvCounter = true;
+ request.key = 'key';
+
+ let correctResult = {
+ "body": 0,
+ "status": 200 
+ };
+
+ endpoint(request, response).then((testResult) => {
+
+ assert.equal(testResult.status, correctResult.status, 'status');
+ assert.equal(testResult.body, correctResult.body, 'response body');
+
+ done();
+ });
+ });
+
  it('fails to kvstore.incrCounter', function (done) {
 
  let request = Object.assign({}, endpointRequestObject);
@@ -333,7 +393,35 @@ describe('#endpoint', () => {
  request.value = 123;
 
  let correctResult = {
- "body": null,
+ "body": 123,
+ "status": 200 
+ };
+
+ endpoint(request, response).then((testResult) => {
+
+ assert.equal(testResult.status, correctResult.status, 'status');
+ assert.equal(testResult.body, correctResult.body, 'response body');
+
+ done();
+ });
+ });
+
+ it('increments a kvstore "incrCounter" value that has been mocked', function (done) {
+ 
+ let request = Object.assign({}, endpointRequestObject);
+ let response = Object.assign({}, endpointResponseObject);
+
+ let preExistingValue = { "key" : 10 };
+
+ // Mock a pre-existing KVStore value for this test only
+ endpoint.mockKVStoreCounters(preExistingValue);
+
+ request.incKvValue = true;
+ request.key = 'key';
+ request.value = 3;
+
+ let correctResult = {
+ "body": 13,
  "status": 200 
  };