Skip to content

Conversation

@bazarnov
Copy link
Contributor

What

#6657 - Source GAv4: Connection check succeeds but sync fails

How

  • added TestStreamConnection class
  • changed the check_connection method to be able to run test read to check the permissions
  • corrected unit_tests

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@bazarnov bazarnov self-assigned this Oct 27, 2021
@github-actions github-actions bot added the area/connectors Connector related issues label Oct 27, 2021
@bazarnov bazarnov requested review from antixar and midavadim October 27, 2021 13:23
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Oct 27, 2021
@bazarnov bazarnov linked an issue Oct 27, 2021 that may be closed by this pull request
@bazarnov bazarnov temporarily deployed to more-secrets October 27, 2021 13:24 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 27, 2021 13:26 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 27, 2021 13:43 Inactive
@bazarnov
Copy link
Contributor Author

bazarnov commented Oct 27, 2021

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1390420054
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1390420054
Python tests coverage:

 ---------- coverage: platform linux, python 3.8.10-final-0 ----------- Name Stmts Miss Cover ------------------------------------------------------------------------ source_acceptance_test/__init__.py 2 0 100% source_acceptance_test/base.py 10 4 60% source_acceptance_test/config.py 74 8 89% source_acceptance_test/conftest.py 108 108 0% source_acceptance_test/plugin.py 47 47 0% source_acceptance_test/tests/__init__.py 4 0 100% source_acceptance_test/tests/test_core.py 200 94 53% source_acceptance_test/tests/test_full_refresh.py 18 11 39% source_acceptance_test/tests/test_incremental.py 69 38 45% source_acceptance_test/utils/__init__.py 6 0 100% source_acceptance_test/utils/asserts.py 37 2 95% source_acceptance_test/utils/common.py 41 24 41% source_acceptance_test/utils/compare.py 47 20 57% source_acceptance_test/utils/connector_runner.py 82 49 40% source_acceptance_test/utils/json_schema_helper.py 115 14 88% ------------------------------------------------------------------------ TOTAL 860 419 51% ---------- coverage: platform linux, python 3.8.10-final-0 ----------- Name Stmts Miss Cover ------------------------------------------------------------ source_google_analytics_v4/__init__.py 2 0 100% source_google_analytics_v4/source.py 231 89 61% ------------------------------------------------------------ TOTAL 233 89 62% 
@bazarnov bazarnov temporarily deployed to more-secrets October 27, 2021 13:52 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 27, 2021 13:53 Inactive
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bazarnov
Copy link
Contributor Author

bazarnov commented Oct 28, 2021

/publish connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1395790942
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1395790942

@jrhizor jrhizor temporarily deployed to more-secrets October 28, 2021 17:51 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets October 28, 2021 18:01 Inactive
@bazarnov bazarnov merged commit 97e9b13 into master Oct 28, 2021
@bazarnov bazarnov deleted the bazarnov/6657-gav4-permission-error branch October 28, 2021 18:10
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation

5 participants