Skip to content

Conversation

@avida
Copy link
Contributor

@avida avida commented Sep 8, 2021

What

Fixes #5820

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 8, 2021
@avida
Copy link
Contributor Author

avida commented Sep 8, 2021

/test connector=connectors/source-sendgrid

🕑 connectors/source-sendgrid https://github.com/airbytehq/airbyte/actions/runs/1213555047
✅ connectors/source-sendgrid https://github.com/airbytehq/airbyte/actions/runs/1213555047

@avida avida force-pushed the drezchykov/5820-sendgrind-add-single-send-stats branch from a056e3b to 2550bee Compare September 8, 2021 13:42
Copy link
Contributor

@Zirochkaa Zirochkaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You created this branch from drezchykov/5828-fix-okta-incr and not from master branch. Please fix this.

@avida avida force-pushed the drezchykov/5820-sendgrind-add-single-send-stats branch from 2550bee to b1940ff Compare September 8, 2021 15:09
@avida avida requested a review from Zirochkaa September 8, 2021 15:10
@avida
Copy link
Contributor Author

avida commented Sep 8, 2021

@Zirochkaa done

@avida avida requested a review from sherifnada September 9, 2021 09:13
@avida avida changed the title Sendgrind add single send stats 🎉 Sendgrind add single send stats Sep 9, 2021
@avida
Copy link
Contributor Author

avida commented Sep 9, 2021

/publish connector=connectors/source-sendgrid

🕑 connectors/source-sendgrid https://github.com/airbytehq/airbyte/actions/runs/1218219309
❌ connectors/source-sendgrid https://github.com/airbytehq/airbyte/actions/runs/1218219309

@jrhizor jrhizor temporarily deployed to more-secrets September 9, 2021 17:05 Inactive
@avida
Copy link
Contributor Author

avida commented Sep 9, 2021

/publish connector=connectors/source-sendgrid

🕑 connectors/source-sendgrid https://github.com/airbytehq/airbyte/actions/runs/1218266576
✅ connectors/source-sendgrid https://github.com/airbytehq/airbyte/actions/runs/1218266576

@jrhizor jrhizor temporarily deployed to more-secrets September 9, 2021 17:19 Inactive
@avida avida merged commit 2ecc7a6 into master Sep 9, 2021
@avida avida deleted the drezchykov/5820-sendgrind-add-single-send-stats branch September 9, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation

5 participants