Source Mailchimp: handle records with no no "activity" field in response #5024

vovavovavovavova · 2021-07-27T13:51:51Z

What

How

The email-activity web response usually contains the set of fields, including "activity" - main resource field. Using our data, we always receiving this field, it may be an empty array, but it always exist. In the issue we might have unexpected case that response does not contain this field, so it fails with an exception. Now those records are skipped, like it was on empty array - additional reason that the cursor field is located inside this field.
Since we cannot debug user data, assuming this can close the issue.
Some schemas were changed too.

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

Issue acceptance criteria met
PR name follows PR naming conventions
Secrets are annotated with airbyte_secret in the connector's spec
Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
Unit & integration tests added as appropriate (and are passing)
- Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
/test connector=connectors/<name> command as documented here is passing.
- Community members can skip this, Airbyters will run this for you.
Code reviews completed
Documentation updated
- README.md
- docs/SUMMARY.md if it's a new connector
- Created or updated reference docs in docs/integrations/<source or destination>/<name>.
- Changelog in the appropriate page in docs/integrations/.... See changelog example
- docs/integrations/README.md contains a reference to the new connector
- Build status added to build page
Build is successful
Connector version bumped like described here
New Connector version released on Dockerhub by running the /publish command described here
No major blockers
PR merged into master branch
Follow up tickets have been created
Associated tickets have been closed & stakeholders notified

Connector Generator checklist

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

vovavovavovavova · 2021-07-27T13:53:23Z

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1071407504
✅ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1071407504

avida · 2021-07-27T13:57:33Z

airbyte-integrations/connectors/source-mailchimp/source_mailchimp/streams.py

 # -> [[{'campaign_id', 'list_id', 'list_is_active', 'email_id', 'email_address', '**activity[i]', '_links'}, ...]]
 data = response_json[self.data_field]
 for item in data:
- for activity_record in item["activity"]:


mb just

for activity_record in item.get("activity", []):

?

vovavovavovavova · 2021-07-27T14:16:04Z

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1071488754
✅ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1071488754

keu · 2021-07-27T14:19:28Z

airbyte-integrations/connectors/source-mailchimp/source_mailchimp/streams.py

+ for activity_record in item["activity"]:
+ new_record = {k: v for k, v in item.items() if k != "activity"}
+ for k, v in activity_record.items():
+ new_record[k] = v
+ yield new_record


or somthing like this

Suggested change

for activity_record in item["activity"]:

new_record = {k: v for k, v in item.items() if k != "activity"}

for k, v in activity_record.items():

new_record[k] = v

yield new_record

for activity_item in item.pop("activity", []):

yield {**item, **activity_item}

keu

see comment

vovavovavovavova · 2021-07-27T14:57:14Z

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1071628590
✅ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1071628590

…ible_mailchimp_data_change

vovavovavovavova · 2021-07-28T14:17:48Z

/publish connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1075209224
✅ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1075209224

sherifnada · 2021-07-28T18:10:58Z

@vovavovavovavova please remember to add the 🎉 emoji to the PR title to make it visible for changelog writers

vovavovavovavova added 2 commits July 27, 2021 16:46

cover if no "activity" field in response

750340f

add new file for sat pass

190438f

github-actions bot added the area/connectors Connector related issues label Jul 27, 2021

vovavovavovavova requested review from Zirochkaa, avida, htrueman, keu and yevhenii-ldv July 27, 2021 13:52

vovavovavovavova changed the title ~~cover if no "activity" field in response~~ Source Mailchimp: handle records with no no "activity" field in response Jul 27, 2021

avida reviewed Jul 27, 2021

View reviewed changes

one line

9141a5d

keu reviewed Jul 27, 2021

View reviewed changes

vovavovavovavova requested review from vitaliizazmic and removed request for Zirochkaa, htrueman and yevhenii-ldv July 27, 2021 14:21

apply cosmetics suggestion

5402859

keu approved these changes Jul 28, 2021

View reviewed changes

vovavovavovavova added 3 commits July 28, 2021 17:10

Merge remote-tracking branch 'origin/master' into valdemar/#4787_poss…

ff96d03

…ible_mailchimp_data_change

bump version

60cf241

upd doc log

9e0bf44

github-actions bot added the area/documentation Improvements or additions to documentation label Jul 28, 2021

vovavovavovavova merged commit 283731b into master Jul 28, 2021

vovavovavovavova deleted the valdemar/#4787_possible_mailchimp_data_change branch July 28, 2021 14:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Source Mailchimp: handle records with no no "activity" field in response #5024

Source Mailchimp: handle records with no no "activity" field in response #5024

Uh oh!

vovavovavovavova commented Jul 27, 2021

vovavovavovavova commented Jul 27, 2021 •

edited by github-actions bot

Loading

avida Jul 27, 2021

vovavovavovavova commented Jul 27, 2021 •

edited by github-actions bot

Loading

keu Jul 27, 2021 •

edited

Loading

keu left a comment

vovavovavovavova commented Jul 27, 2021 •

edited by github-actions bot

Loading

vovavovavovavova commented Jul 28, 2021 •

edited by github-actions bot

Loading

sherifnada commented Jul 28, 2021

Labels

5 participants

Source Mailchimp: handle records with no no "activity" field in response #5024

Source Mailchimp: handle records with no no "activity" field in response #5024

Uh oh!

Conversation

vovavovavovavova commented Jul 27, 2021

What

How

Recommended reading order

Pre-merge Checklist

vovavovavovavova commented Jul 27, 2021 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

avida Jul 27, 2021

Choose a reason for hiding this comment

vovavovavovavova commented Jul 27, 2021 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

keu Jul 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

keu left a comment

Choose a reason for hiding this comment

vovavovavovavova commented Jul 27, 2021 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

vovavovavovavova commented Jul 28, 2021 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

sherifnada commented Jul 28, 2021

Labels

5 participants

vovavovavovavova commented Jul 27, 2021 •

edited by github-actions bot

Loading

vovavovavovavova commented Jul 27, 2021 •

edited by github-actions bot

Loading

keu Jul 27, 2021 •

edited

Loading

vovavovavovavova commented Jul 27, 2021 •

edited by github-actions bot

Loading

vovavovavovavova commented Jul 28, 2021 •

edited by github-actions bot

Loading