Skip to content

🚨🚨Source Hubspot: add property history streams for Deals and Companies #33266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 12, 2023
Merged

🚨🚨Source Hubspot: add property history streams for Deals and Companies #33266

merged 10 commits into from
Dec 12, 2023

Conversation

@roman-yermilov-gl
Copy link
Contributor

@roman-yermilov-gl roman-yermilov-gl commented Dec 8, 2023

What

Property History stream should contain data for Deals and Companies in addition to Contacts: https://github.com/airbytehq/product-request-backlog/issues/25

How

Migrate PropertyHistory to ContactsPropertyHistory
Add CompaniesPropertyHistory stream
Add DealsPropertyHistory stream
Made refactoring
Add unit tests
@roman-yermilov-gl roman-yermilov-gl self-assigned this Dec 8, 2023
@vercel
Copy link

vercel bot commented Dec 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 8:35pm
@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Dec 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023 •
edited by roman-yermilov-gl
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.
@roman-yermilov-gl roman-yermilov-gl removed the request for review from artem1205 December 8, 2023 19:35
@roman-yermilov-gl roman-yermilov-gl marked this pull request as ready for review December 8, 2023 19:39
@octavia-squidington-iv octavia-squidington-iv requested review from a team December 8, 2023 19:40
bnchrch
bnchrch approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@bnchrch bnchrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from an ops perspective
@roman-yermilov-gl roman-yermilov-gl force-pushed the ryermilov/source-hubspot-property-hisotry-deals-companies branch from 1b5d5ca to c0d73af Compare December 8, 2023 21:27
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Dec 8, 2023
@octavia-squidington-iv octavia-squidington-iv requested a review from a team December 8, 2023 21:28
@roman-yermilov-gl roman-yermilov-gl force-pushed the ryermilov/source-hubspot-property-hisotry-deals-companies branch from 007cd4b to 1a242a9 Compare December 8, 2023 22:53
@roman-yermilov-gl roman-yermilov-gl added the breaking-change Don't merge me unless you are ready. label Dec 11, 2023
katmarkham
katmarkham requested changes Dec 11, 2023
View reviewed changes
airbyte-integrations/connectors/source-hubspot/metadata.yaml Outdated
Copy link
Contributor

@katmarkham katmarkham Dec 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version eliminates the PropertyHistory stream in favor of creating 3 different streams, Contacts, Companies, and Deals, which can now all fetch their property history.
It will affect only users who use PropertyHistory stream, who will need to fix schema conflicts in replication tab and sync ContactsPropertyHistory stream instead of PropertyHistory.
Copy link
Contributor Author

@roman-yermilov-gl roman-yermilov-gl Dec 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
@octavia-squidington-iv octavia-squidington-iv requested a review from a team December 11, 2023 16:26
@roman-yermilov-gl roman-yermilov-gl force-pushed the ryermilov/source-hubspot-property-hisotry-deals-companies branch from 133017b to c2b57ad Compare December 11, 2023 16:41
@roman-yermilov-gl roman-yermilov-gl changed the title Source Hubspot: add property history streams for Deals and Companies 🚨🚨Source Hubspot: add property history streams for Deals and Companies Dec 11, 2023
@roman-yermilov-gl roman-yermilov-gl force-pushed the ryermilov/source-hubspot-property-hisotry-deals-companies branch from 3a0eae5 to 6ba72ae Compare December 12, 2023 17:28
katmarkham
katmarkham requested changes Dec 12, 2023
View reviewed changes
docs/integrations/sources/hubspot-migrations.md Outdated

## Upgrading to 2.0.0

Note: this change is only breaking if you are using PropertyHistory stream
Copy link
Contributor

@katmarkham katmarkham Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this change is only breaking if you are using the PropertyHistory stream.
docs/integrations/sources/hubspot-migrations.md Outdated

Note: this change is only breaking if you are using PropertyHistory stream

With this update, we have access to historical property changes for Deals and Companies, just like we have it for Contacts. That is why Property History stream was renamed to Contacts Property History and two new streams were added: Deals Property History and Companies Property History.
Copy link
Contributor

@katmarkham katmarkham Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this update, you can now access historical property changes for Deals and Companies, in addition to Contacts. Property History stream has been renamed to Contacts Property History (since it historically contained historical property changes from Contacts) and two new streams were added: Deals Property History and Companies Property History.
This is a breaking change because Property History has been replaced with Contacts Property History, so please follow the instructions below to migrate to version 2.0.0:
@octavia-squidington-iv octavia-squidington-iv requested a review from a team December 12, 2023 18:12
@roman-yermilov-gl roman-yermilov-gl merged commit 8bd60a9 into master Dec 12, 2023
@roman-yermilov-gl roman-yermilov-gl deleted the ryermilov/source-hubspot-property-hisotry-deals-companies branch December 12, 2023 21:29
rishabh-cldcvr pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Dec 14, 2023
@roman-yermilov-gl @rishabh-cldcvr
🚨🚨Source Hubspot: add property history streams for Deals and Companies (
c01e359 
airbytehq#33266)
tmathew0309 pushed a commit to tmathew0309/airbyte that referenced this pull request Jan 12, 2024
@roman-yermilov-gl @tmathew0309
🚨🚨Source Hubspot: add property history streams for Deals and Companies (
382005a 
airbytehq#33266)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation breaking-change Don't merge me unless you are ready. connectors/source/hubspot

6 participants

@roman-yermilov-gl @bnchrch @katmarkham @lazebnyi @octavia-squidington-iii