Skip to content

✨Source Stripe: New Stream - Persons #26208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 14, 2023
Merged

✨Source Stripe: New Stream - Persons #26208

merged 14 commits into from
Jul 14, 2023

Conversation

@btkcodedev
Copy link
Collaborator

@btkcodedev btkcodedev commented May 17, 2023

What

Closes #16965

Enhancement

New streams:

  • Persons

Recommended reading order

  1. source_stripe/source.py
  2. source_stripe/streams.py
  3. source_stripe/schemas/*

🚨 User Impact 🚨

No breaking changes

Pre-merge Checklist

Updating a connector

Community member or Airbyter [Yes]

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Documentation which references the generator is updated as needed
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels May 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2023 •
edited by midavadim
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You, or an Airbyter, have run /publish successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file new!

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.
@btkcodedev btkcodedev changed the title 🎉Source Stripe: New Streams - Persons 🎉Source Stripe: New Stream - Persons May 17, 2023
@btkcodedev btkcodedev changed the title 🎉Source Stripe: New Stream - Persons 🎉Source Stripe: New Stream - Organization Fields May 20, 2023
@btkcodedev btkcodedev changed the title 🎉Source Stripe: New Stream - Organization Fields 🎉Source Stripe: New Stream - Persons May 20, 2023
@marcosmarxm marcosmarxm added the contributor-program PRs submitted through the contributor program. label May 22, 2023
archangelic
archangelic suggested changes May 22, 2023
View reviewed changes
Copy link
Contributor

@archangelic archangelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I have added some suggested changes. Let me know if there are any questions.
@jrolom jrolom removed the bounty label May 29, 2023
@btkcodedev btkcodedev changed the title 🎉Source Stripe: New Stream - Persons ✨Source Stripe: New Stream - Persons Jun 4, 2023
@btkcodedev btkcodedev requested a review from archangelic June 4, 2023 08:32
@marcosmarxm
Copy link
Contributor

marcosmarxm commented Jun 8, 2023

@archangelic can we get an update in this contribution?
@archangelic
Copy link
Contributor

archangelic commented Jun 9, 2023

Looks like there just needs two areas with changes, then we can continue with getting this merged!
@lazebnyi lazebnyi requested a review from davydov-d July 6, 2023 14:51
@lazebnyi lazebnyi requested review from midavadim and removed request for davydov-d July 6, 2023 16:09
@midavadim midavadim mentioned this pull request Jul 14, 2023
Closed
@midavadim midavadim merged commit 0a2cd5f into airbytehq:master Jul 14, 2023
@midavadim
Copy link
Contributor

midavadim commented Jul 14, 2023

Related PR with CI tests:
#28322
efimmatytsin pushed a commit to scentbird/airbyte that referenced this pull request Jul 27, 2023
@btkcodedev @archangelic
@midavadim @efimmatytsin
✨Source Stripe: New Stream - Persons (airbytehq#26208)
fcf2727 
* Initial Commit * EOF * Update airbyte-integrations/connectors/source-stripe/source_stripe/streams.py Co-authored-by: Mal Hancock <mhancock@archangelic.space> * Resolve Comments * fix unittest * fix SAT * fix schema --------- Co-authored-by: Mal Hancock <mhancock@archangelic.space> Co-authored-by: midavadim <midavadim@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/stripe contributor-program PRs submitted through the contributor program. gl gl-review team/connectors-python

7 participants

@btkcodedev @marcosmarxm @archangelic @midavadim @octavia-squidington-iii @bmcgilli @jrolom