Skip to content

Source Gitlab: fix missing data issue #21713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 24, 2023
Merged

Source Gitlab: fix missing data issue #21713

merged 6 commits into from
Jan 24, 2023

Conversation

@davydov-d
Copy link
Contributor

@davydov-d davydov-d commented Jan 23, 2023

What

#21076

How

Build request params from stream slice instead of state
@davydov-d davydov-d linked an issue Jan 23, 2023 that may be closed by this pull request
Gitlab Source is only loading 50 rows per project #21076
Closed
@octavia-squidington-iv octavia-squidington-iv added connectors/source/gitlab area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jan 23, 2023
@davydov-d
Copy link
Contributor Author

davydov-d commented Jan 23, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/3988390785
✅ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/3988390785
Python tests coverage:

Name Stmts Miss Cover ----------------------------------------------- source_gitlab/__init__.py 2 0 100% source_gitlab/source.py 61 3 95% source_gitlab/streams.py 271 14 95% ----------------------------------------------- TOTAL 334 17 95% Name Stmts Miss Cover Missing ---------------------------------------------------------------------------------- source_acceptance_test/base.py 12 4 67% 16-19 source_acceptance_test/config.py 141 5 96% 87, 93, 239, 243-244 source_acceptance_test/conftest.py 211 95 55% 36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358 source_acceptance_test/plugin.py 69 25 64% 22-23, 31, 36, 120-140, 144-148 source_acceptance_test/tests/test_core.py 402 115 71% 53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776 source_acceptance_test/tests/test_incremental.py 160 14 91% 58-65, 70-83, 246 source_acceptance_test/utils/asserts.py 39 2 95% 62-63 source_acceptance_test/utils/common.py 94 10 89% 16-17, 32-38, 72, 75 source_acceptance_test/utils/compare.py 62 23 63% 21-51, 68, 97-99 source_acceptance_test/utils/connector_runner.py 133 33 75% 24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208 source_acceptance_test/utils/json_schema_helper.py 107 13 88% 30-31, 38, 41, 65-68, 96, 120, 192-194 ---------------------------------------------------------------------------------- TOTAL 1609 339 79%

Build Passed

Test summary info:

=========================== short test summary info ============================ SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical. SKIPPED [2] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical. ================== 42 passed, 3 skipped in 570.26s (0:09:30) ===================
@davydov-d
Copy link
Contributor Author

davydov-d commented Jan 23, 2023 •
edited by github-actions bot
Loading

/publish connector=connectors/source-gitlab

🕑 Publishing the following connectors:
connectors/source-gitlab
https://github.com/airbytehq/airbyte/actions/runs/3988881483


Connector Did it publish? Were definitions generated?
connectors/source-gitlab ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 23, 2023 17:55 — with GitHub Actions Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 23, 2023 17:55 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2023 •
edited
Loading

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 26.68% 🍏
@davydov-d davydov-d temporarily deployed to more-secrets January 23, 2023 18:24 — with GitHub Actions Inactive
@davydov-d davydov-d temporarily deployed to more-secrets January 23, 2023 18:24 — with GitHub Actions Inactive
@davydov-d davydov-d temporarily deployed to more-secrets January 23, 2023 18:58 — with GitHub Actions Inactive
@davydov-d davydov-d temporarily deployed to more-secrets January 23, 2023 18:58 — with GitHub Actions Inactive
@davydov-d davydov-d temporarily deployed to more-secrets January 23, 2023 19:29 — with GitHub Actions Inactive
@davydov-d davydov-d temporarily deployed to more-secrets January 23, 2023 19:30 — with GitHub Actions Inactive
@davydov-d davydov-d merged commit 06e8884 into master Jan 24, 2023
@davydov-d davydov-d deleted the ddavydov/#21076-source-gitlab-fix-missing-records branch January 24, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/gitlab

5 participants

@davydov-d @lazebnyi @octavia-squidington-iii @octavia-squidington-iv