🪟🔧 Refactor frontend destination routing #19120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actions bot added area/platform 
joeykmh commented Nov 9, 2022
Comment on lines +48 to +56
| <Route path={RoutePaths.Destination}> | ||
| <Route index element={<AllDestinationsPage />} /> | ||
| <Route path={DestinationPaths.NewDestination} element={<CreateDestinationPage />} /> | ||
| <Route path={DestinationPaths.NewConnection} element={<CreationFormPage />} /> | ||
| <Route path={DestinationPaths.Root} element={<DestinationItemPage />}> | ||
| <Route path={DestinationPaths.Settings} element={<DestinationSettingsPage />} /> | ||
| <Route index element={<DestinationOverviewPage />} /> | ||
| </Route> | ||
| </Route> |
Author
There was a problem hiding this comment.
This is the main improvement introduced in this PR - we can see the route structure clearly.
joeykmh changed the title 
krishnaglick approved these changes Nov 15, 2022
Contributor
krishnaglick left a comment
krishnaglick left a comment There was a problem hiding this comment.
I like the work being done here! Did some light testing, clicking around in OSS and that all seems to work 👍
akashkulk pushed a commit that referenced this pull request Dec 2, 2022
* move components out of pages directory * flatten destination routes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What
This PR refactors the routes nested in the destination path:
/workspaces/:workspaceId/destinationWith the aim of:
pagesand into thecomponentsdirectoryroutes.tsxfile for less nesting and better discoverability<Route>components) from application specific componentsPart of a larger effort to clean up our frontend routing logic.
How
src/components/destination<Route>components have been moved up toroutes.tsxso that the whole route tree becomes more visible (see these changes)<Routes>have been replaced with react-router's <Outlet> componentRecommended reading order
routes.tsxandroutePaths.tsxto see the broad picturepages/destinationto see the purely routing componentssrc/components/destinationto see the application components related to thedestinationapp domainNext steps
A similar refactor will be done for sources, connections and settings so that we do not have so many deeply nested and conditional
<Route>components.