Bmoric/extract webbackend api #18988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…irbyte into bmoric/extract-scheduler-api
…ract-operation-api
…irbyte into bmoric/extract-scheduler-api
…ract-scheduler-api
github-actions bot added area/platform …ract-webbackend-api
benmoriceau requested review from alovew, colesnodgrass, gosusnp and jdpgrailsdev Contributor Author
| I manually tested this PR locally because of the risk of changing the webbackend API. |
alovew approved these changes Nov 8, 2022
colesnodgrass added a commit that referenced this pull request Nov 8, 2022
This reverts commit b05a5b2.
colesnodgrass added a commit that referenced this pull request Nov 8, 2022
This reverts commit ebef6e4.
colesnodgrass added a commit that referenced this pull request Nov 10, 2022
* init attempt at initcontainer * wait for init container to be up instead of main container * copy files to init container * Revert "Bmoric/extract webbackend api (#18988)" This reverts commit b05a5b2. * Revert "Revert "Bmoric/extract webbackend api (#18988)"" This reverts commit ebef6e4. * block on initContainer status; cleanup init script * add log messages * add quotes to log messages * pr feedback, add comment to bash script
akashkulk pushed a commit that referenced this pull request Dec 2, 2022
* Extract Operation API * Extract scheduler API * Format * extract source api * Extract source definition api * Add path * Extract State API * extract webbackend api * extract webbackend api * Fix build
akashkulk pushed a commit that referenced this pull request Dec 2, 2022
* init attempt at initcontainer * wait for init container to be up instead of main container * copy files to init container * Revert "Bmoric/extract webbackend api (#18988)" This reverts commit b05a5b2. * Revert "Revert "Bmoric/extract webbackend api (#18988)"" This reverts commit ebef6e4. * block on initContainer status; cleanup init script * add log messages * add quotes to log messages * pr feedback, add comment to bash script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What
In order to be prepared for a smoother migration to Micronaut for the server, an effort must be made to break the ConfigurationApi into multiple classes. This PR is the first one of a series of PR to come.
How
Extract the WebBackendApi into its own class
Recommended reading order
No specific order