Skip to content

Conversation

@tuliren
Copy link
Contributor

@tuliren tuliren commented Aug 5, 2022

What

  • A few internal anchors in the Postgres doc referenced by the spec.json file were accidentally deleted.
  • This PR fixes the links in the spec.json file by using existing links to the relevant subtitles.
@tuliren tuliren force-pushed the liren/fix-postgres-spec-link branch from 8a656eb to e1619f1 Compare August 5, 2022 22:33
@github-actions github-actions bot added area/documentation Improvements or additions to documentation and removed area/connectors Connector related issues labels Aug 5, 2022
@tuliren tuliren marked this pull request as ready for review August 5, 2022 22:34
@tuliren tuliren changed the title 📄 Postgres source: fix links in the spec file 📄 Postgres source: add back internal anchors in doc Aug 5, 2022
@tuliren tuliren requested review from a team and grishick August 5, 2022 22:35
@tuliren tuliren mentioned this pull request Aug 5, 2022
@tuliren tuliren requested a review from misteryeo August 5, 2022 22:37
@tuliren
Copy link
Contributor Author

tuliren commented Aug 5, 2022

Actually we don't need the anchor. Can just reuse the subtitle. Will update.

@github-actions github-actions bot added the area/connectors Connector related issues label Aug 5, 2022
@github-actions github-actions bot removed the area/documentation Improvements or additions to documentation label Aug 5, 2022
@tuliren tuliren changed the title 📄 Postgres source: add back internal anchors in doc 📄 Postgres source: fix links in the spec Aug 5, 2022
@tuliren tuliren merged commit 71d0f00 into greg/src-postgres-toga Aug 5, 2022
@tuliren tuliren deleted the liren/fix-postgres-spec-link branch August 5, 2022 22:50
tuliren added a commit that referenced this pull request Aug 6, 2022
* Label source-postgres to GA * Correct the PR number * 📄 Postgres source: fix links in the spec (#15382) * Add internal anchors back * Remove internal anchor * Use links for subtitles * Remove one more anchor * auto-bump connector version [ci skip] Co-authored-by: Liren Tu <tuliren.git@outlook.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants