Skip to content

#12605 Added "end_date" field for source Mixpanel in specs #12801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 30, 2022
Merged

#12605 Added "end_date" field for source Mixpanel in specs #12801

merged 4 commits into from
May 30, 2022

Conversation

@michael-c-nguyen
Copy link
Contributor

@michael-c-nguyen michael-c-nguyen commented May 12, 2022

What

Adding the "end_date" into the config map of specs.json because it is referred to in the source.py of the source_mixpanel.

How

We followed the similar format of the "start_date" and also the "end_date" of other sources config files.

Recommended reading order

  1. spec.json

Tests

Since this is config related there are no test cases available.
@github-actions github-actions bot added the area/connectors Connector related issues label May 12, 2022
marcosmarxm
marcosmarxm approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contributon @michaelnguyen26 maybe a small addition, wdyt?
@marcosmarxm marcosmarxm self-assigned this May 12, 2022
@michael-c-nguyen
Copy link
Contributor Author

michael-c-nguyen commented May 12, 2022 •
edited
Loading

thanks for the contributon @michaelnguyen26 maybe a small addition, wdyt?

Sure @marcosmarxm that makes sense, your suggestion is added! Thank you.
@marcosmarxm
Copy link
Contributor

marcosmarxm commented May 27, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/2394033482
✅ connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/2394033482
Python tests coverage:

Name Stmts Miss Cover ------------------------------------------------------------------------ source_acceptance_test/utils/__init__.py 6 0 100% source_acceptance_test/tests/__init__.py 4 0 100% source_acceptance_test/__init__.py 2 0 100% source_acceptance_test/tests/test_full_refresh.py 52 2 96% source_acceptance_test/utils/asserts.py 37 2 95% source_acceptance_test/config.py 74 6 92% source_acceptance_test/utils/json_schema_helper.py 105 13 88% source_acceptance_test/utils/common.py 80 17 79% source_acceptance_test/utils/compare.py 62 23 63% source_acceptance_test/tests/test_core.py 285 106 63% source_acceptance_test/base.py 10 4 60% source_acceptance_test/utils/connector_runner.py 110 48 56% source_acceptance_test/tests/test_incremental.py 69 38 45% ------------------------------------------------------------------------ TOTAL 896 259 71% Name Stmts Miss Cover ------------------------------------------------- source_mixpanel/__init__.py 2 0 100% source_mixpanel/source.py 340 57 83% ------------------------------------------------- TOTAL 342 57 83%
Cheryl0402 and others added 3 commits May 30, 2022 14:44
@github-actions github-actions bot added area/api Related to the api area/platform issues related to the platform CDK Connector Development Kit normalization area/documentation Improvements or additions to documentation and removed CDK Connector Development Kit area/platform issues related to the platform normalization area/api Related to the api labels May 30, 2022
@marcosmarxm
Copy link
Contributor

marcosmarxm commented May 30, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/2410594153
❌ Failed to publish connectors/source-mixpanel
❌ Couldn't auto-bump version for connectors/source-mixpanel
@marcosmarxm
Copy link
Contributor

marcosmarxm commented May 30, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-mixpanel run-tests=false

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/2410972025
🚀 Successfully published connectors/source-mixpanel
🚀 Auto-bumped version for connectors/source-mixpanel
✅ connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/2410972025
@marcosmarxm marcosmarxm merged commit ab81e4d into airbytehq:master May 30, 2022
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request May 31, 2022
Merged
jscottpolevault pushed a commit to jscottpolevault/airbyte that referenced this pull request Jun 1, 2022
@michael-c-nguyen @Cheryl0402
@marcosmarxm @octavia-squidington-iii
Source Mixpanel: Added "end_date" field in specs (airbytehq#12801)
0d9da64 
* Added end_date for source mixpanel * Update airbyte-integrations/connectors/source-mixpanel/source_mixpanel/spec.json Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> * add end_date * auto-bump connector version Co-authored-by: Cheryl0402 <yi.cheryl.chen@gmail.com> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
@marcosmarxm marcosmarxm mentioned this pull request Jun 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation community

4 participants

@michael-c-nguyen @marcosmarxm @octavia-squidington-iii @Cheryl0402