Skip to content

Conversation

@bazarnov
Copy link
Contributor

@bazarnov bazarnov commented Apr 4, 2022

What

Need to make documentation corrections up to MLP Review

How

  • edited spec.json: Title
  • edited online documentation to reflect the corrections for MLP requirements

🚨 User Impact 🚨

No impact expected.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
@bazarnov bazarnov self-assigned this Apr 4, 2022
@github-actions github-actions bot added the area/connectors Connector related issues label Apr 4, 2022
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Apr 4, 2022
@bazarnov
Copy link
Contributor Author

bazarnov commented Apr 4, 2022

/test connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/2089229929
✅ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/2089229929
Python tests coverage:

Name Stmts Miss Cover ------------------------------------------------------------------------ source_acceptance_test/utils/__init__.py 6 0 100% source_acceptance_test/tests/__init__.py 4 0 100% source_acceptance_test/__init__.py 2 0 100% source_acceptance_test/tests/test_full_refresh.py 52 2 96% source_acceptance_test/utils/asserts.py 37 2 95% source_acceptance_test/config.py 74 6 92% source_acceptance_test/utils/json_schema_helper.py 105 13 88% source_acceptance_test/utils/common.py 70 17 76% source_acceptance_test/utils/compare.py 62 23 63% source_acceptance_test/tests/test_core.py 275 106 61% source_acceptance_test/base.py 10 4 60% source_acceptance_test/utils/connector_runner.py 110 48 56% source_acceptance_test/tests/test_incremental.py 69 38 45% ------------------------------------------------------------------------ TOTAL 876 259 70% Name Stmts Miss Cover -------------------------------------------------------- source_zendesk_support/__init__.py 2 0 100% source_zendesk_support/streams.py 290 57 80% source_zendesk_support/source.py 45 25 44% -------------------------------------------------------- TOTAL 337 82 76% 
@bazarnov bazarnov temporarily deployed to more-secrets April 4, 2022 10:25 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets April 4, 2022 10:25 Inactive
@bazarnov bazarnov requested a review from misteryeo April 4, 2022 10:42
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@24d7ab1). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 9ebea7b differs from pull request most recent head 07a4a3a. Consider uploading reports for the commit 07a4a3a to get more accurate results

@@ Coverage Diff @@ ## master #11688 +/- ## ========================================= Coverage ? 75.66% ========================================= Files ? 3 Lines ? 337 Branches ? 0 ========================================= Hits ? 255 Misses ? 82 Partials ? 0 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24d7ab1...07a4a3a. Read the comment docs.

@bazarnov
Copy link
Contributor Author

bazarnov commented Apr 4, 2022

/publish connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/2092641544
✅ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/2092641544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation

3 participants