Skip to content

🐛 Source Hubspot: fix casting of float numbers #11105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 16, 2022
Merged

🐛 Source Hubspot: fix casting of float numbers #11105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
43616a8
upd documentation
annalvova05 Mar 10, 2022
0691689
fix comma in float number
annalvova05 Mar 14, 2022
129bed9
bump version
annalvova05 Mar 14, 2022
d7cb05f
add unit test for float casting
annalvova05 Mar 16, 2022
bdbb1f5
Merge remote-tracking branch 'origin/master' into alvova/10533-hubspot
annalvova05 Mar 16, 2022
7958ce7
Merge remote-tracking branch 'origin/alvova/10533-hubspot' into alvov…
annalvova05 Mar 16, 2022
3949451
bump version
annalvova05 Mar 16, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@
- name: HubSpot
sourceDefinitionId: 36c891d9-4bd9-43ac-bad2-10e12756272c
dockerRepository: airbyte/source-hubspot
dockerImageTag: 0.1.47
dockerImageTag: 0.1.48
documentationUrl: https://docs.airbyte.io/integrations/sources/hubspot
icon: hubspot.svg
sourceType: api
Expand Down
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_specs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3331,7 +3331,7 @@
supportsNormalization: false
supportsDBT: false
supported_destination_sync_modes: []
- dockerImage: "airbyte/source-hubspot:0.1.47"
- dockerImage: "airbyte/source-hubspot:0.1.48"
spec:
documentationUrl: "https://docs.airbyte.io/integrations/sources/hubspot"
connectionSpecification:
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-hubspot/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ COPY source_hubspot ./source_hubspot
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.47
LABEL io.airbyte.version=0.1.48
LABEL io.airbyte.name=airbyte/source-hubspot
1 change: 1 addition & 0 deletions airbyte-integrations/connectors/source-hubspot/source_hubspot/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,7 @@ def _cast_value(cls, declared_field_types: List, field_name: str, field_value: A
if target_type_name == "number":
# do not cast numeric IDs into float, use integer instead
target_type = int if field_name.endswith("_id") else target_type
field_value = field_value.replace(",", "")

if target_type_name != "string" and field_value == "":
# do not cast empty strings, return None instead to be properly casted.
Expand Down
1 change: 1 addition & 0 deletions airbyte-integrations/connectors/source-hubspot/unit_tests/test_field_type_converting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ def test_bad_field_type_converting(field_type, expected, caplog, capsys):
# specific cases
("string", "some_field", "test", None, "test"),
(["null", "number"], "some_field", "123.456", None, 123.456),
(["null", "number"], "some_field", "123,123.456", None, 123123.456),
(["null", "number"], "user_id", "123", None, 123),
(["null", "string"], "some_field", "123", None, "123"),
# when string has empty field_value (empty string)
Expand Down
Loading