- Notifications
You must be signed in to change notification settings - Fork 4.9k
🐛 Source Hubspot: fix casting of float numbers #11105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #11105 +/- ## ========================================= Coverage ? 83.39% ========================================= Files ? 4 Lines ? 753 Branches ? 0 ========================================= Hits ? 628 Misses ? 125 Partials ? 0 Continue to review full report at Codecov.
|
bazarnov left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add some little unit_test to cover the issue of the case?
airbyte-integrations/connectors/source-hubspot/source_hubspot/streams.py Show resolved Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@annalvova05 feel free to publish and merge once baz's comments are addressed!
# Conflicts: # airbyte-integrations/connectors/source-hubspot/Dockerfile # docs/integrations/sources/hubspot.md
| /test connector=connectors/source-hubspot
|
| /publish connector=connectors/source-hubspot
|
What
Close #10533 and #10463.
How
Fix float numbers casting. Update documentation.
Recommended reading order
streams.pyhubspot.md🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described here