Skip to content

Conversation

@annalvova05
Copy link
Contributor

What

Close #10533 and #10463.

How

Fix float numbers casting. Update documentation.

Recommended reading order

  1. streams.py
  2. hubspot.md

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
@annalvova05 annalvova05 requested a review from bazarnov March 14, 2022 11:18
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Mar 14, 2022
@annalvova05 annalvova05 temporarily deployed to more-secrets March 14, 2022 11:22 Inactive
@annalvova05 annalvova05 temporarily deployed to more-secrets March 14, 2022 11:22 Inactive
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@96588ed). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 7958ce7 differs from pull request most recent head 3949451. Consider uploading reports for the commit 3949451 to get more accurate results

@@ Coverage Diff @@ ## master #11105 +/- ## ========================================= Coverage ? 83.39% ========================================= Files ? 4 Lines ? 753 Branches ? 0 ========================================= Hits ? 628 Misses ? 125 Partials ? 0 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96588ed...3949451. Read the comment docs.

Copy link
Contributor

@bazarnov bazarnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some little unit_test to cover the issue of the case?

@annalvova05 annalvova05 requested a review from bazarnov March 14, 2022 12:01
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annalvova05 feel free to publish and merge once baz's comments are addressed!

@annalvova05 annalvova05 temporarily deployed to more-secrets March 16, 2022 10:18 Inactive
@annalvova05 annalvova05 temporarily deployed to more-secrets March 16, 2022 10:18 Inactive
# Conflicts: #	airbyte-integrations/connectors/source-hubspot/Dockerfile #	docs/integrations/sources/hubspot.md
@annalvova05 annalvova05 temporarily deployed to more-secrets March 16, 2022 10:24 Inactive
@annalvova05
Copy link
Contributor Author

annalvova05 commented Mar 16, 2022

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1992649035
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1992649035
Python tests coverage:

Name Stmts Miss Cover ------------------------------------------------------------------------ source_acceptance_test/utils/__init__.py 6 0 100% source_acceptance_test/tests/__init__.py 4 0 100% source_acceptance_test/__init__.py 2 0 100% source_acceptance_test/tests/test_full_refresh.py 52 2 96% source_acceptance_test/utils/asserts.py 37 2 95% source_acceptance_test/config.py 74 6 92% source_acceptance_test/utils/json_schema_helper.py 105 13 88% source_acceptance_test/utils/common.py 70 17 76% source_acceptance_test/utils/compare.py 62 23 63% source_acceptance_test/tests/test_core.py 275 106 61% source_acceptance_test/base.py 10 4 60% source_acceptance_test/utils/connector_runner.py 110 48 56% source_acceptance_test/tests/test_incremental.py 69 38 45% ------------------------------------------------------------------------ TOTAL 876 259 70% Name Stmts Miss Cover ------------------------------------------------ source_hubspot/errors.py 6 0 100% source_hubspot/__init__.py 2 0 100% source_hubspot/streams.py 682 109 84% source_hubspot/source.py 69 16 77% ------------------------------------------------ TOTAL 759 125 84% 
@annalvova05
Copy link
Contributor Author

annalvova05 commented Mar 16, 2022

/publish connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1992710255
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1992710255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation

4 participants