Skip to content

Commit fc05f65

Browse files
🐛Source Freshdesk: Fix schema types (#20416)
* Fix schema types * Updated version * Updated acceptance tests * auto-bump connector version Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
1 parent 4e4800b commit fc05f65

File tree

8 files changed

+166
-123
lines changed

8 files changed

+166
-123
lines changed

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -516,7 +516,7 @@
516516
- name: Freshdesk
517517
sourceDefinitionId: ec4b9503-13cb-48ab-a4ab-6ade4be46567
518518
dockerRepository: airbyte/source-freshdesk
519-
dockerImageTag: 1.0.0
519+
dockerImageTag: 2.0.0
520520
documentationUrl: https://docs.airbyte.com/integrations/sources/freshdesk
521521
icon: freshdesk.svg
522522
sourceType: api

airbyte-config/init/src/main/resources/seed/source_specs.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4386,7 +4386,7 @@
43864386
supportsNormalization: false
43874387
supportsDBT: false
43884388
supported_destination_sync_modes: []
4389-
- dockerImage: "airbyte/source-freshdesk:1.0.0"
4389+
- dockerImage: "airbyte/source-freshdesk:2.0.0"
43904390
spec:
43914391
documentationUrl: "https://docs.airbyte.com/integrations/sources/freshdesk"
43924392
connectionSpecification:

airbyte-integrations/connectors/source-freshdesk/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,5 +34,5 @@ COPY source_freshdesk ./source_freshdesk
3434
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
3535
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
3636

37-
LABEL io.airbyte.version=1.0.0
37+
LABEL io.airbyte.version=2.0.0
3838
LABEL io.airbyte.name=airbyte/source-freshdesk

airbyte-integrations/connectors/source-freshdesk/acceptance-test-config.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,21 @@ acceptance_tests:
1717
- config_path: "secrets/config.json"
1818
# please remove the backward_capability checks bypass, once updated to the newer version
1919
backward_compatibility_tests_config:
20-
disable_for_version: "0.3.8"
20+
disable_for_version: "1.0.0"
2121
basic_read:
2222
tests:
2323
- config_path: "secrets/config.json"
2424
expect_records:
2525
path: "integration_tests/expected_records.jsonl"
26+
extra_fields: no
27+
exact_order: no
28+
extra_records: yes
2629
timeout_seconds: 600
30+
empty_streams:
31+
- name: skills
32+
bypass_reason: "no records"
33+
- name: products
34+
bypass_reason: "no records"
2735
incremental:
2836
tests:
2937
- config_path: "secrets/config.json"

airbyte-integrations/connectors/source-freshdesk/integration_tests/expected_records.jsonl

Lines changed: 132 additions & 113 deletions
Large diffs are not rendered by default.

airbyte-integrations/connectors/source-freshdesk/setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from setuptools import find_packages, setup
77

88
MAIN_REQUIREMENTS = [
9-
"airbyte-cdk~=0.2",
9+
"airbyte-cdk",
1010
"backoff==1.10.0",
1111
"requests==2.25.1",
1212
"pendulum==2.1.2",

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/schemas/sla_policies.json

Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,10 @@
138138
"type": ["null", "integer"]
139139
},
140140
"agent_ids": {
141-
"type": ["null", "integer"]
141+
"type": ["null", "array"],
142+
"items": {
143+
"type": ["null", "integer"]
144+
}
142145
}
143146
}
144147
},
@@ -152,7 +155,10 @@
152155
"type": ["null", "integer"]
153156
},
154157
"agent_ids": {
155-
"type": ["null", "integer"]
158+
"type": ["null", "array"],
159+
"items": {
160+
"type": ["null", "integer"]
161+
}
156162
}
157163
}
158164
},
@@ -163,7 +169,10 @@
163169
"type": ["null", "integer"]
164170
},
165171
"agent_ids": {
166-
"type": ["null", "integer"]
172+
"type": ["null", "array"],
173+
"items": {
174+
"type": ["null", "integer"]
175+
}
167176
}
168177
}
169178
},
@@ -174,7 +183,10 @@
174183
"type": ["null", "integer"]
175184
},
176185
"agent_ids": {
177-
"type": ["null", "integer"]
186+
"type": ["null", "array"],
187+
"items": {
188+
"type": ["null", "integer"]
189+
}
178190
}
179191
}
180192
},
@@ -185,7 +197,10 @@
185197
"type": ["null", "integer"]
186198
},
187199
"agent_ids": {
188-
"type": ["null", "integer"]
200+
"type": ["null", "array"],
201+
"items": {
202+
"type": ["null", "integer"]
203+
}
189204
}
190205
}
191206
}

docs/integrations/sources/freshdesk.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ The Freshdesk connector should not run into Freshdesk API limitations under norm
6767

6868
| Version | Date | Pull Request | Subject |
6969
|:--------|:-----------|:---------------------------------------------------------|:--------------------------------------------------------------------------------------|
70+
| 2.0.0 | 2022-12-20 | [20416](https://github.com/airbytehq/airbyte/pull/20416) | Fix `SlaPolicies` stream schema |
7071
| 1.0.0 | 2022-11-16 | [19496](https://github.com/airbytehq/airbyte/pull/19496) | Fix `Contacts` stream schema |
7172
| 0.3.8 | 2022-11-11 | [19349](https://github.com/airbytehq/airbyte/pull/19349) | Do not rely on response.json() when deciding to retry a request |
7273
| 0.3.7 | 2022-11-03 | [18397](https://github.com/airbytehq/airbyte/pull/18397) | Fix base url for v2 API. |

0 commit comments

Comments
 (0)