Skip to content

Commit 8a42960

Browse files
authored
SAT: check for nullity of docker runner in previous_discovered_catalog (#20899)
1 parent 64254a4 commit 8a42960

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

airbyte-integrations/bases/source-acceptance-test/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# Changelog
22

3+
## 0.2.24
4+
Check for nullity of docker runner in `previous_discovered_catalog_fixture`.[#20899](https://github.com/airbytehq/airbyte/pull/20899)
5+
36
## 0.2.23
47
Skip backward compatibility tests on specifications if actual and previous specifications and discovered catalogs are identical.[#20435](https://github.com/airbytehq/airbyte/pull/20435)
58

airbyte-integrations/bases/source-acceptance-test/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ COPY pytest.ini setup.py ./
3333
COPY source_acceptance_test ./source_acceptance_test
3434
RUN pip install .
3535

36-
LABEL io.airbyte.version=0.2.23
36+
LABEL io.airbyte.version=0.2.24
3737
LABEL io.airbyte.name=airbyte/source-acceptance-test
3838

3939
ENTRYPOINT ["python", "-m", "pytest", "-p", "source_acceptance_test.plugin", "-r", "fEsx"]

airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/conftest.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,11 @@ def previous_discovered_catalog_fixture(
272272
connector_config, previous_connector_docker_runner: ConnectorRunner, previous_cached_schemas
273273
) -> MutableMapping[str, AirbyteStream]:
274274
"""JSON schemas for each stream"""
275+
if previous_connector_docker_runner is None:
276+
logging.warning(
277+
"\n We could not retrieve the previous discovered catalog as a connector runner for the previous connector version could not be instantiated."
278+
)
279+
return None
275280
if not previous_cached_schemas:
276281
output = previous_connector_docker_runner.call_discover(config=connector_config)
277282
catalogs = [message.catalog for message in output if message.type == Type.CATALOG]

0 commit comments

Comments
 (0)