feat: Improve key generation and certificate parsing with formatted expiration date

Author: yashikota

src/crypto.ts

@@ -20,14 +20,6 @@ import {X509Certificate} from '@peculiar/x509';
 import {Convert} from 'pvtsutils';
 
 export async function generateKeys(): Promise<RSAKeys> {
- // Check for Web Crypto API support
- if (!crypto?.subtle) {
- throw new CloudSQLConnectorError({
- message: 'Web Crypto API is not available in this environment',
- code: 'ENOCRYPTO',
- });
- }
-
  const keyPair = await crypto.subtle.generateKey(
  {
  name: 'RSA-PSS',
@@ -50,7 +42,7 @@ export async function generateKeys(): Promise<RSAKeys> {
  );
 
  // Convert to base64 and format as PEM
- const privateKeyPem = `-----BEGIN PRIVATE KEY-----\n${arrayBufferToBase64(privateKeyExport)}\n-----END PRIVATE KEY-----`;
+ const privateKeyPem = `-----BEGIN RSA PRIVATE KEY-----\n${arrayBufferToBase64(privateKeyExport)}\n-----END RSA PRIVATE KEY-----`;
  const publicKeyPem = `-----BEGIN PUBLIC KEY-----\n${arrayBufferToBase64(publicKeyExport)}\n-----END PUBLIC KEY-----`;
 
  return {
@@ -78,9 +70,13 @@ export async function parseCert(cert: string): Promise<SslCert> {
  });
  }
 
+ const date = x509.notAfter;
+ const months = ['Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun', 'Jul', 'Aug', 'Sep', 'Oct', 'Nov', 'Dec'];
+ const formattedDate = `${months[date.getUTCMonth()]} ${String(date.getUTCDate()).padStart(2)} ${String(date.getUTCHours()).padStart(2, '0')}:${String(date.getUTCMinutes()).padStart(2, '0')}:${String(date.getUTCSeconds()).padStart(2, '0')} ${date.getUTCFullYear()} GMT`;
+
  return {
  cert,
- expirationTime: x509.notAfter.toISOString(),
+ expirationTime: formattedDate,
  };
  } catch (err: unknown) {
  throw new CloudSQLConnectorError({

test/crypto.ts

@@ -50,12 +50,8 @@ t.test('parseCert failure', async t => {
 
 t.test('parseCert missing expiration time', async t => {
  const {parseCert} = t.mockRequire('../src/crypto', {
- '../src/node-crypto': {
- async cryptoModule() {
- return {
- X509Certificate: class {},
- };
- },
+ '@peculiar/x509': {
+ X509Certificate: class {},
  },
  });
  return t.rejects(