#55700: Move the Memcached container into the Docker Compose config #2689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
johnbillion changed the title johnbillion force-pushed the local-memcached branch from 54e5d57 to 903493b Compare johnbillion requested review from SergeyBiryukov, aaronjorbin, desrosj and hellofromtonya 
desrosj approved these changes Aug 11, 2022
Member
desrosj left a comment
desrosj left a comment There was a problem hiding this comment.
Tested and looks great for me on MacOS.
Member Author
westonruter reviewed Sep 11, 2022
| const containers = ( process.env.LOCAL_PHP_MEMCACHED === 'true' ) | ||
| ? 'wordpress-develop memcached' | ||
| : 'wordpress-develop'; | ||
| execSync( `docker-compose up -d -- ${containers}`, { stdio: 'inherit' } ); |
Member
There was a problem hiding this comment.
@johnbillion Is there a specific reason for the inclusion of -- here? I found that it causes an error in docker-compose, at least in v1.25.0 on Linux:
npm run env:start > WordPress@6.1.0 env:start /home/westonruter/repos/wordpress-develop > node ./tools/local-env/scripts/start.js Creating network "wordpress-develop_wpdevnet" with driver "bridge" ERROR: No such service: -- child_process.js:866 throw err; ^ Error: Command failed: docker-compose up -d -- wordpress-develop at checkExecSyncError (child_process.js:790:11) at execSync (child_process.js:863:15) at Object.<anonymous> (/home/westonruter/repos/wordpress-develop/tools/local-env/scripts/start.js:11:1) at Module._compile (internal/modules/cjs/loader.js:1085:14) at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10) at Module.load (internal/modules/cjs/loader.js:950:32) at Function.Module._load (internal/modules/cjs/loader.js:790:12) at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:75:12) at internal/main/run_main_module.js:17:47 { status: 1, signal: null, output: [ null, null, null ], pid: 8626, stdout: null, stderr: null } npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! WordPress@6.1.0 env:start: `node ./tools/local-env/scripts/start.js` npm ERR! Exit status 1 If I remove the -- then the command runs successfully.
Member Author
There was a problem hiding this comment.
I assume there was a reason but I don't remember it. Can you open a ticket? 👍
Member
There was a problem hiding this comment.
Here you go: https://core.trac.wordpress.org/ticket/56550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/55700
This moves the Memcached container into the Docker Compose config so it can be used with the local dev environment just by flipping the
LOCAL_PHP_MEMCACHEDenvironment variable value.Testing
Ensure Docker Desktop is running if necessary.
Test with the object cache enabled:
.envfile enable the memcached config viaLOCAL_PHP_MEMCACHED=truenpm run env:restartobject-cache.phpdrop-in is present on http://localhost:8889/wp-admin/plugins.php?plugin_status=dropinsTest with the object cache disabled:
.envfile disable the memcached config viaLOCAL_PHP_MEMCACHED=falsenpm run env:restartobject-cache.phpdrop-in is no longer present on http://localhost:8889/wp-admin/plugins.php?plugin_status=dropins