Skip to content

Commit 258beb6

Browse files
authored
Merge pull request #16 from Wikia/SqlBuilderMixin-columns-handling
SqlBuilderMixin: wrap column names in backticks
2 parents b4d4918 + 9bf2479 commit 258beb6

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ dist/
66
venv/
77
*.iml
88
.idea
9+
*.swp
910

1011
coverage.xml
1112
env/

wikia/common/mw_database/build.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"version": "1.0.5",
2+
"version": "1.0.6",
33
"description": "Mediawiki database connector",
44
"install_requires": [
55
"MySQL-python==1.2.5",

wikia/common/mw_database/query_builder.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def insert(self, table, data, ignore_errors=False):
4242
values = []
4343
sql_data = {}
4444
for column, value in data.items():
45-
columns.append(column)
45+
columns.append('`{}`'.format(column))
4646
sql_value, is_value = self.add_value(value, sql_data, column)
4747
if not is_value:
4848
raise ValueError('insert accepts only value literals')

0 commit comments

Comments
 (0)