Merge pull request #81 from Vonage/audit

Various fixes from code snippet audit

Author: hummusonrails

.env-example

@@ -18,4 +18,10 @@ NUMBER_SEARCH_PATTERN=
 SMS_CALLBACK_URL= 
 VOICE_CALLBACK_TYPE= 
 VOICE_CALLBACK_VALUE= 
-VOICE_STATUS_URL= 
+VOICE_STATUS_URL= 
+
+# Vonage SMS API variables
+VONAGE_BRAND_NAME=
+
+# Vonage Account API variables
+VONAGE_SECRET_ID=

Gemfile

@@ -1,10 +1,11 @@
 source 'https://rubygems.org'
 
-gem 'dotenv', '2.1.1'
+gem 'dotenv', '2.7.6'
 gem 'faye-websocket', '0.11.0'
-gem 'nexmo', '~> 7.2.0'
-gem 'sinatra', '2.0.5'
-gem 'sinatra-contrib', '2.0.5'
-gem 'thin', '1.7.0'
+gem 'vonage', '~> 7.2.1'
+gem 'sinatra', '2.1.0'
+gem 'sinatra-contrib', '2.1.0'
+gem 'rack-contrib', '2.3.0'
+gem 'thin', '1.8.0'
 gem 'rubocop', require: false
 gem "byebug", "~> 11.0"

Gemfile.lock

@@ -2,29 +2,27 @@ GEM
  remote: https://rubygems.org/
  specs:
  ast (2.4.0)
- backports (3.15.0)
  byebug (11.0.1)
  daemons (1.3.1)
- dotenv (2.1.1)
+ dotenv (2.7.6)
  eventmachine (1.2.7)
  faye-websocket (0.11.0)
  eventmachine (>= 0.12.0)
  websocket-driver (>= 0.5.1)
  jaro_winkler (1.5.3)
- jwt (2.2.1)
- multi_json (1.13.1)
- mustermann (1.0.3)
- nexmo (7.2.0)
- nexmo-jwt (~> 0.1.1)
- sorbet-runtime (~> 0.5)
- zeitwerk (~> 2, >= 2.2)
- nexmo-jwt (0.1.1)
+ jwt (2.2.2)
+ multi_json (1.15.0)
+ mustermann (1.1.1)
+ ruby2_keywords (~> 0.0.1)
+ nexmo-jwt (0.1.2)
  jwt (~> 2)
  parallel (1.17.0)
  parser (2.6.3.0)
  ast (~> 2.4.0)
  rack (2.2.3)
- rack-protection (2.0.5)
+ rack-contrib (2.3.0)
+ rack (~> 2.0)
+ rack-protection (2.1.0)
  rack
  rainbow (3.0.0)
  rubocop (0.72.0)
@@ -35,42 +33,47 @@ GEM
  ruby-progressbar (~> 1.7)
  unicode-display_width (>= 1.4.0, < 1.7)
  ruby-progressbar (1.10.1)
- sinatra (2.0.5)
+ ruby2_keywords (0.0.4)
+ sinatra (2.1.0)
  mustermann (~> 1.0)
- rack (~> 2.0)
- rack-protection (= 2.0.5)
+ rack (~> 2.2)
+ rack-protection (= 2.1.0)
  tilt (~> 2.0)
- sinatra-contrib (2.0.5)
- backports (>= 2.8.2)
+ sinatra-contrib (2.1.0)
  multi_json
  mustermann (~> 1.0)
- rack-protection (= 2.0.5)
- sinatra (= 2.0.5)
- tilt (>= 1.3, < 3)
- sorbet-runtime (0.5.5859)
- thin (1.7.0)
+ rack-protection (= 2.1.0)
+ sinatra (= 2.1.0)
+ tilt (~> 2.0)
+ sorbet-runtime (0.5.6281)
+ thin (1.8.0)
  daemons (~> 1.0, >= 1.0.9)
  eventmachine (~> 1.0, >= 1.0.4)
  rack (>= 1, < 3)
- tilt (2.0.9)
+ tilt (2.0.10)
  unicode-display_width (1.6.0)
+ vonage (7.2.1)
+ nexmo-jwt (~> 0.1.2)
+ sorbet-runtime (~> 0.5)
+ zeitwerk (~> 2, >= 2.2)
  websocket-driver (0.7.3)
  websocket-extensions (>= 0.1.0)
  websocket-extensions (0.1.5)
- zeitwerk (2.4.0)
+ zeitwerk (2.4.2)
 
 PLATFORMS
  ruby
 
 DEPENDENCIES
  byebug (~> 11.0)
- dotenv (= 2.1.1)
+ dotenv (= 2.7.6)
  faye-websocket (= 0.11.0)
- nexmo (~> 7.2.0)
+ rack-contrib (= 2.3.0)
  rubocop
- sinatra (= 2.0.5)
- sinatra-contrib (= 2.0.5)
- thin (= 1.7.0)
+ sinatra (= 2.1.0)
+ sinatra-contrib (= 2.1.0)
+ thin (= 1.8.0)
+ vonage (~> 7.2.1)
 
 BUNDLED WITH
- 1.17.2
+ 2.2.3

number-insight/ni-standard.rb

@@ -3,15 +3,15 @@
 
 VONAGE_API_KEY = ENV['VONAGE_API_KEY']
 VONAGE_API_SECRET = ENV['VONAGE_API_SECRET']
-SEARCH_NUMBER = ENV['SEARCH_NUMBER']
+INSIGHT_NUMBER = ENV['INSIGHT_NUMBER']
 
 client = Vonage::Client.new(
  api_key: VONAGE_API_KEY,
  api_secret: VONAGE_API_SECRET
 )
 
 insight = client.number_insight.standard(
- number: SEARCH_NUMBER
+ number: INSIGHT_NUMBER
 )
 
 puts insight.inspect

voice/dtmf.rb

@@ -20,6 +20,11 @@ def parsed_body
  },
  {
  action: 'input',
+ type: [ 'dtmf' ],
+ dtmf: {
+ 'maxDigits': 1,
+ 'timeOut': 5
+ },
  eventUrl: ["#{request.base_url}/webhooks/dtmf"]
  }
  ].to_json
@@ -30,7 +35,7 @@ def parsed_body
 
  [{
  action: 'talk',
- text: "You pressed #{dtmf}"
+ text: "You pressed #{dtmf['digits']}"
  }].to_json
 end