All code snippets for v1 messages #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
superchilled left a comment
superchilled left a comment There was a problem hiding this comment.
Looks good overall. I've suggested some different variable names, and also added a couple of questions.
Co-authored-by: Karl Lingiah <karl@superchilled.co.uk>
Co-authored-by: Karl Lingiah <karl@superchilled.co.uk>
Co-authored-by: Karl Lingiah <karl@superchilled.co.uk>
Co-authored-by: Karl Lingiah <karl@superchilled.co.uk>
Co-authored-by: Karl Lingiah <karl@superchilled.co.uk>
Co-authored-by: Karl Lingiah <karl@superchilled.co.uk>
Co-authored-by: Karl Lingiah <karl@superchilled.co.uk>
Co-authored-by: Karl Lingiah <karl@superchilled.co.uk>
Contributor
superchilled left a comment
superchilled left a comment There was a problem hiding this comment.
Missed a few of the var name changes.
Co-authored-by: Karl Lingiah <karl@superchilled.co.uk>
Co-authored-by: Karl Lingiah <karl@superchilled.co.uk>
Co-authored-by: Karl Lingiah <karl@superchilled.co.uk>
Co-authored-by: Karl Lingiah <karl@superchilled.co.uk>
Co-authored-by: Karl Lingiah <karl@superchilled.co.uk>
Co-authored-by: Karl Lingiah <karl@superchilled.co.uk>
Co-authored-by: Karl Lingiah <karl@superchilled.co.uk>
Co-authored-by: Karl Lingiah <karl@superchilled.co.uk>
Co-authored-by: Karl Lingiah <karl@superchilled.co.uk>
Co-authored-by: Karl Lingiah <karl@superchilled.co.uk>
Co-authored-by: Karl Lingiah <karl@superchilled.co.uk>
superchilled approved these changes Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This adds all the code snippets for Messages v1