Verify Search and Workflow-based Request #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dragonmantank requested review from adamculp, lornajane and mheap and removed request for mheap 
lornajane suggested changes Oct 10, 2019
Contributor
lornajane left a comment
lornajane left a comment There was a problem hiding this comment.
I don't get the usage information if I don't supply extra arguments, I just do like "php search.php" as I would with the other examples in this repo - and it errors. Can we make this friendlier if the user didn't supply the expected data? Things do seem to work if you get the commands right (but I had to read the code to achieve this)
dragonmantank force-pushed the verify-search-and-workflow-request branch from a08d9b1 to efd9bcb Compare lornajane approved these changes Nov 26, 2019
Contributor
lornajane left a comment
lornajane left a comment There was a problem hiding this comment.
This looks good, thanks for regrouping (and for being so patient!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Added snippets for searching and sending a verify with a specified workflow ID