Skip to content

Conversation

@marklewin
Copy link

New PHP Numbers API snippets for:

  • List owned numbers
  • Search numbers available for purchase
  • Purchase number
  • Cancel number
  • Update number
@marklewin marklewin requested a review from lornajane May 14, 2019 12:53
@marklewin
Copy link
Author

marklewin commented May 16, 2019

@lornajane For the "list owned" and "search available" examples I'd like to be able to say "Here are 10 of your 18 matching numbers" (or whatever) to remind devs that the results are paginated. However, I can't seem to access the count property in the response. Any suggestions?

@lornajane
Copy link
Contributor

I think the missing count property is a bug, but we'd need a breaking change to fix it. Want to open an issue on the PHP lib for it?

@lornajane lornajane force-pushed the markl-add-numbers-api-snippets branch from 9088602 to fa6027b Compare May 17, 2019 10:31
Copy link
Contributor

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I patched something minor and the error handling isn't great in the PHP lib but these snippets do the job. Nice work!

@lornajane
Copy link
Contributor

Also: most of these examples are missing from the PHP lib README and it would be nice to have them there too.

@marklewin marklewin merged commit 0f02c4c into master May 17, 2019
@marklewin marklewin deleted the markl-add-numbers-api-snippets branch May 17, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants