Add Notify building block #27
Conversation
| 'action' => 'notify', | ||
| 'payload' => ['foo' => 'bar'], | ||
| 'eventUrl' => [ | ||
| $uri->getScheme().'://'.$uri->getHost().':'.$uri->getPort().'/webhooks/dtmf' |
There was a problem hiding this comment.
Should this URL be /webhooks/notification ? I don't see /webhooks/dtmf defined.
lornajane left a comment
lornajane left a comment There was a problem hiding this comment.
The testing instructions should show it in action, not responding to a curl request. Other than the non-matching URL, the code works well and I would also love it if we included a really basic /event endpoint too, what do you think?
| | ||
| * Run `composer install` | ||
| * Start the web server `php -t . -S 127.0.0.1:3000` | ||
| * Test your code with the following `curl` requests: |
There was a problem hiding this comment.
Could we show how to test it in a voice context? I can copy and paste the curl commands but I'm not sure what I've tested or how to use this code in my application.
There was a problem hiding this comment.
I realise this is copy/paste from the incoming call example, but I still think we could make a more useful test for a user.
mheap force-pushed the notify-building-block branch from b60fb68 to 98a0f5c Compare | @lornajane Good spot on the URL. I've updated the event URL and add an event webhook handler. As far as updating the README I'm not sure what we could add in there short of writing detailed VAPI instructions. As this is consistent with our existing blocks I'd like to merge and get the Notify example in the docs and we can look at the quickstart READMEs as a separate issue (see #28) |
No description provided.