Handle incorrect scheme when accessing via ngrok #16
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When switching between using this example directly on http://localhost:8080 and the same but with ngrok in front https://somethingsomething.ngrok.io then we lose the scheme* and it always assumes HTTP, not HTTPS, because it ignores the HTTP_X_FORWARDED_PROTO for security reasons. For this situation, where we want to support the header, we can use https://github.com/akrabat/rka-scheme-and-host-detection-middleware.
This pull request adds it for the
record-a-messagebuilding block only, but if we agree this is useful, I'll roll it out for the others (4 or 5 others in the voice folder using Slim are affected I think , it's basically when we need to build a URL in an NCCO).