Use our standard placeholder variable names #13
Conversation
mheap left a comment
mheap left a comment There was a problem hiding this comment.
Looks like there's only one example that uses API_KEY and API_SECRET that needs updating too https://github.com/nexmo-community/nexmo-php-quickstart/blob/d969e243bb5a11b0ee5296bf50ba7b40212aa215/sms/send-with-slim/index.php#L13
| Got carried away and added a readme as well. Could you take another look please? |
| $client = new Nexmo\Client(new Nexmo\Client\Credentials\Basic(API_KEY, API_SECRET)); | ||
| $text = new \Nexmo\Message\Text($args['number'], NEXMO_FROM_NUMBER, $body['text']); | ||
| $client = new Nexmo\Client(new Nexmo\Client\Credentials\Basic(NEXMO_API_KEY, NEXMO_API_SECRET)); | ||
| $text = new \Nexmo\Message\Text($args['number'], FROM, $body['text']); |
There was a problem hiding this comment.
When config.php is included it iterates over $_ENV and defines a constant for each key. This is how NEXMO_API_KEY and NEXMO_API_SECRET have values.
Following that, FROM should be FROM_NUMBER as that's the name in .env
There was a problem hiding this comment.
I think it's .env that wants updating then, FROM is our standard placeholder.
| This commit changes the |
I noticed that the
.env-exampleusedAPI_KEYrather thanNEXMO_API_KEYwhich the code seemed to expect, so I changed it to match.