Skip to content

Commit 3a4d894

Browse files
committed
Lower default GridFS chunk size to 255k, PYTHON-661.
1 parent d02352c commit 3a4d894

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

gridfs/grid_file.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@
4545
NEWLN = b("\n")
4646

4747
"""Default chunk size, in bytes."""
48-
DEFAULT_CHUNK_SIZE = 256 * 1024
48+
# Slightly under a power of 2, to work well with server's record allocations.
49+
DEFAULT_CHUNK_SIZE = 255 * 1024
4950

5051

5152
def _create_property(field_name, docstring,

test/test_grid_file.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ def test_grid_in_default_opts(self):
124124
self.assertRaises(AttributeError, getattr, a, "length")
125125
self.assertRaises(AttributeError, setattr, a, "length", 5)
126126

127-
self.assertEqual(256 * 1024, a.chunk_size)
127+
self.assertEqual(255 * 1024, a.chunk_size)
128128
self.assertRaises(AttributeError, setattr, a, "chunk_size", 5)
129129

130130
self.assertRaises(AttributeError, getattr, a, "upload_date")
@@ -157,7 +157,7 @@ def test_grid_in_default_opts(self):
157157
self.assertEqual(0, a.length)
158158
self.assertRaises(AttributeError, setattr, a, "length", 5)
159159

160-
self.assertEqual(256 * 1024, a.chunk_size)
160+
self.assertEqual(255 * 1024, a.chunk_size)
161161
self.assertRaises(AttributeError, setattr, a, "chunk_size", 5)
162162

163163
self.assertTrue(isinstance(a.upload_date, datetime.datetime))
@@ -216,7 +216,7 @@ def test_grid_out_default_opts(self):
216216
self.assertEqual(None, b.content_type)
217217
self.assertEqual(None, b.name)
218218
self.assertEqual(None, b.filename)
219-
self.assertEqual(256 * 1024, b.chunk_size)
219+
self.assertEqual(255 * 1024, b.chunk_size)
220220
self.assertTrue(isinstance(b.upload_date, datetime.datetime))
221221
self.assertEqual(None, b.aliases)
222222
self.assertEqual(None, b.metadata)

test/test_gridfs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ def test_empty_file(self):
130130
self.assertEqual(0, raw["length"])
131131
self.assertEqual(oid, raw["_id"])
132132
self.assertTrue(isinstance(raw["uploadDate"], datetime.datetime))
133-
self.assertEqual(256 * 1024, raw["chunkSize"])
133+
self.assertEqual(255 * 1024, raw["chunkSize"])
134134
self.assertTrue(isinstance(raw["md5"], basestring))
135135

136136
def test_alt_collection(self):

0 commit comments

Comments
 (0)