Skip to content

Commit 21fc63f

Browse files
Finish all todos for GitHub related stuff
1 parent d404d49 commit 21fc63f

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

gui.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -611,9 +611,9 @@ def create_edit_menu(self) -> None:
611611
self.edit_menu = tk.Menu(self.menu_bar)
612612
self.menu_bar.add_cascade(menu=self.edit_menu, label="Edit", underline=0)
613613
self.edit_menu.add_command(label="Open .cpypmconfig",
614-
command=lambda: open_application(str(self.cpypmconfig_path)), underline=6)
614+
command=lambda: self.open_file(str(self.cpypmconfig_path)), underline=6)
615615
self.edit_menu.add_command(label="Open .cpypmconfig file location",
616-
command=lambda: open_application(str(self.cpypmconfig_path.parent)), underline=23)
616+
command=lambda: self.open_file(str(self.cpypmconfig_path.parent)), underline=23)
617617
self.edit_menu.add_separator()
618618
self.edit_menu.add_command(label="Save changes", command=self.save_modified, underline=0,
619619
accelerator=self.make_key_bind(ctrl_cmd=True, mac_ctrl=False, shift=False,
@@ -665,8 +665,8 @@ def create_help_menu(self) -> None:
665665
"""
666666
self.help_menu = tk.Menu(self.menu_bar)
667667
self.menu_bar.add_cascade(menu=self.help_menu, label="Help", underline=0)
668-
self.help_menu.add_command(label="Open configuration", command=lambda: open_application(str(self.config_path)), underline=5)
669-
self.help_menu.add_command(label="Open logs", command=lambda: open_application(str(Path.cwd() / "log.log")), underline=5)
668+
self.help_menu.add_command(label="Open configuration", command=lambda: self.open_file(str(self.config_path)), underline=5)
669+
self.help_menu.add_command(label="Open logs", command=lambda: self.open_file(str(Path.cwd() / "log.log")), underline=5)
670670
self.help_menu.add_separator()
671671
self.help_menu.add_command(label="Open README.md",
672672
command=self.start_open_readme_thread, underline=5,
@@ -675,10 +675,12 @@ def create_help_menu(self) -> None:
675675
self.convert_to_md_var = tk.BooleanVar(value=True)
676676
self.disable_open_readme = False
677677
self.help_menu.add_checkbutton(label="Convert Markdown to HTML", variable=self.convert_to_md_var, onvalue=True, offvalue=False)
678-
# TODO: Implement opening the project on GitHub
679-
self.help_menu.add_command(label="Open project on GitHub", state=tk.DISABLED, underline=5)
680-
# TODO: Implement opening an issue on GitHub
681-
self.help_menu.add_command(label="Open issue on GitHub", state=tk.DISABLED, underline=5)
678+
self.help_menu.add_command(label="Open project on GitHub",
679+
command=lambda: self.open_file("https://github.com/UnsignedArduino/CircuitPython-Project-Manager"),
680+
underline=5)
681+
self.help_menu.add_command(label="Open issue on GitHub",
682+
command=lambda: self.open_file("https://github.com/UnsignedArduino/CircuitPython-Project-Manager/issues/new"),
683+
underline=5)
682684

683685
def update_menu_state(self) -> None:
684686
"""

main.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
1616
"""
1717

18-
# TODO: Make public on GitHub
1918
# TODO: Make binaries like in CPY Bundle Manager
2019

2120
import gui

0 commit comments

Comments
 (0)