Skip to content

Commit 6bf8835

Browse files
committed
fix(mumble): buffer overrun in sprintf
Fix a buffer overrun in mumble module due to a sprintf which could occupy 12 bytes including the terminating null to buffer of size 11.
1 parent d3da710 commit 6bf8835

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

mumble.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ deal_with_mumble_packet(struct qserver *server, char *rawpkt, int pktlen)
3333
// skip unimplemented ack, crc, etc
3434
char *pkt = rawpkt;
3535
char bandwidth[11];
36-
char version[11];
36+
char version[12];
3737

3838
server->ping_total += time_delta(&packet_recv_time, &server->packet_time1);
3939
if ((24 != pktlen) || (0 != memcmp(pkt + 4, server->type->status_packet + 4, 8))) {

0 commit comments

Comments
 (0)