Skip to content

Get static field concretly #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2022
Merged

Get static field concretly #904

merged 1 commit into from
Sep 13, 2022

Conversation

@SBOne-Kenobi
Copy link
Collaborator

@SBOne-Kenobi SBOne-Kenobi commented Sep 12, 2022 •
edited
Loading

Description

Prepare to replace reflection with concrete executor for getting static field value.

Fixes #903

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • New tests have been added
  • All tests pass locally with my changes
@SBOne-Kenobi SBOne-Kenobi self-assigned this Sep 12, 2022
@SBOne-Kenobi SBOne-Kenobi force-pushed the sbone/static_field_get_concretly branch from f52c08b to 477b12e Compare September 12, 2022 08:42
@SBOne-Kenobi SBOne-Kenobi marked this pull request as ready for review September 12, 2022 08:43
@SBOne-Kenobi SBOne-Kenobi force-pushed the sbone/static_field_get_concretly branch from 477b12e to 439ff5a Compare September 12, 2022 08:50
Domonion
Domonion approved these changes Sep 12, 2022
View reviewed changes
Copy link
Collaborator

@Domonion Domonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
sergeypospelov
sergeypospelov approved these changes Sep 13, 2022
View reviewed changes
...instrumentation/src/main/kotlin/org/utbot/instrumentation/instrumentation/Instrumentation.kt
parameters: Any? = null
): TInvocationInstrumentation

fun getStaticField(fieldId: FieldId): Result<*>
Copy link
Member

@sergeypospelov sergeypospelov Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need it in a base class?
Copy link
Member

@sergeypospelov sergeypospelov Sep 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed. We will take a look at it later.
@SBOne-Kenobi SBOne-Kenobi force-pushed the sbone/static_field_get_concretly branch from 439ff5a to 24d8fba Compare September 13, 2022 09:13
@SBOne-Kenobi SBOne-Kenobi enabled auto-merge (squash) September 13, 2022 09:16
@SBOne-Kenobi SBOne-Kenobi force-pushed the sbone/static_field_get_concretly branch from 24d8fba to 8cf391c Compare September 13, 2022 09:37
@SBOne-Kenobi SBOne-Kenobi merged commit 463a152 into main Sep 13, 2022
@SBOne-Kenobi SBOne-Kenobi deleted the sbone/static_field_get_concretly branch September 13, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@SBOne-Kenobi @Domonion @sergeypospelov