Skip to content

Conversation

@swrobel
Copy link
Contributor

@swrobel swrobel commented May 7, 2024

Fixes #579

@ShivamKJJW
Copy link

@TimOliver a release required merging this PR as it is a problem with everyone using this repo in RN projects.

@TimOliver TimOliver merged commit 4cb27ef into TimOliver:main May 8, 2024
@TimOliver
Copy link
Owner

Thanks for that @swrobel!

@TimOliver
Copy link
Owner

@ShivamKJJW A release is required... please? 😜

@ShivamKJJW
Copy link

ShivamKJJW commented May 8, 2024

@ShivamKJJW A release is required... please? 😜

Thanks for quick merge. I don't have access to release a new version. You will have to do it. :)

@TimOliver
Copy link
Owner

@ShivamKJJW So I don't actually use React Native. I'm in no rush to push a new release. 😇

Please be mindful in free open source comments to be polite and not demand things. 🙏

@ShivamKJJW
Copy link

@ShivamKJJW So I don't actually use React Native. I'm in no rush to push a new release. 😇

Please be mindful in free open source comments to be polite and not demand things. 🙏

Oh! Please don't mind. I didn't take it in that way. Instead of demanding I was trying to drag your attention to this PR due to its urgency. Anyways got your concern now. Thanks.

It will be really helpful for everyone if you can make a release. 🙏

@TimOliver
Copy link
Owner

@ShivamKJJW Ahh I see! No problem Shivam! Sorry I misunderstood then! I really appreciate that!

I've just shipped a new release under 2.7.4. Please let me know if this resolved the issue or if it needs any follow-up! Thanks!

@ShivamKJJW
Copy link

Thank you so much @TimOliver. Sure, I will check it.

@fred-bowker
Copy link

Hi Tim, thanks for your work on TOCropViewController.
For the release 2.7.4 I can see a tag for this, but no release for it https://github.com/TimOliver/TOCropViewController/releases, can you add a release so that it is clear what the latest version is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants