updated client API with more useful errors, removed unused service reference

Author: jricher

openid-connect-server/src/main/java/org/mitre/openid/connect/web/ClientAPI.java

@@ -24,7 +24,6 @@
 import org.mitre.oauth2.model.ClientDetailsEntity.AuthMethod;
 import org.mitre.oauth2.service.ClientDetailsEntityService;
 import org.mitre.oauth2.web.AuthenticationUtilities;
-import org.mitre.openid.connect.service.UserInfoService;
 import org.mitre.openid.connect.view.ClientEntityViewForAdmins;
 import org.mitre.openid.connect.view.ClientEntityViewForUsers;
 import org.mitre.openid.connect.view.HttpCodeView;
@@ -75,9 +74,6 @@ public class ClientAPI {
 @Autowired
 private ClientDetailsEntityService clientService;
 
-@Autowired
-private UserInfoService userInfoService;
-
 private JsonParser parser = new JsonParser();
 
 private Gson gson = new GsonBuilder()
@@ -239,7 +235,7 @@ public String apiAddClient(@RequestBody String jsonString, Model m, Authenticati
 } catch (IllegalArgumentException e) {
 logger.error("Unable to save client: {}", e.getMessage());
 m.addAttribute(HttpCodeView.CODE, HttpStatus.BAD_REQUEST);
-m.addAttribute(JsonErrorView.ERROR_MESSAGE, "Unable to save client");
+m.addAttribute(JsonErrorView.ERROR_MESSAGE, "Unable to save client: " + e.getMessage());
 return JsonErrorView.VIEWNAME;
 }
 }
@@ -340,7 +336,7 @@ public String apiUpdateClient(@PathVariable("id") Long id, @RequestBody String j
 } catch (IllegalArgumentException e) {
 logger.error("Unable to save client: {}", e.getMessage());
 m.addAttribute(HttpCodeView.CODE, HttpStatus.BAD_REQUEST);
-m.addAttribute(JsonErrorView.ERROR_MESSAGE, "Unable to save client");
+m.addAttribute(JsonErrorView.ERROR_MESSAGE, "Unable to save client: " + e.getMessage());
 return JsonErrorView.VIEWNAME;
 }
 }