Skip to content

Commit 673dbcc

Browse files
author
Guillaume Pinot
committed
Bump minimum rustc version to 1.36
1 parent b57dde1 commit 673dbcc

File tree

3 files changed

+5
-12
lines changed

3 files changed

+5
-12
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ language: rust
22
cache: cargo
33
matrix:
44
include:
5-
- rust: 1.34.0
5+
- rust: 1.36.0
66
- rust: stable
77
- rust: beta
88
- rust: nightly

CHANGELOG.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
# v0.3.0 (2019-06-XX)
1+
# v0.3.0 (2019-08-30)
22

33
## Breaking changes
44

5-
### Bump minimum rustc version to 1.34 by [@TeXitoi](https://github.com/TeXitoi)
6-
Now `rustc` 1.34 is the minimum compiler version supported by `structopt`,
5+
### Bump minimum rustc version to 1.36 by [@TeXitoi](https://github.com/TeXitoi)
6+
Now `rustc` 1.36 is the minimum compiler version supported by `structopt`,
77
it likely won't work with older compilers.
88

99
### Remove "nightly" feature

structopt-derive/src/lib.rs

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -118,18 +118,11 @@ fn gen_augmentation(
118118

119119
let (parser, f) = attrs.parser();
120120
let validator = match **parser {
121-
// clippy v0.0.212 (1fac380 2019-02-20) produces `redundant_closure` warnings
122-
// for `.map_err(|e| e.to_string())` when `e` is a reference
123-
// (e.g. `&'static str`). To suppress the warning, we have to write
124-
// `|e| (&e).to_string()` since `e` may be a reference or non-reference.
125-
// When Rust 1.35 is released, this hack will be obsolete because the next
126-
// stable clippy is going to stop triggering the warning for macros.
127-
// https://github.com/rust-lang/rust-clippy/pull/3816
128121
Parser::TryFromStr => quote! {
129122
.validator(|s| {
130123
#f(&s)
131124
.map(|_: #convert_type| ())
132-
.map_err(|e| (&e).to_string())
125+
.map_err(|e| e.to_string())
133126
})
134127
},
135128
Parser::TryFromOsStr => quote! {

0 commit comments

Comments
 (0)