Add some must have implementations #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| this is frozen, because |
Nyholm suggested changes Jun 23, 2017
composer.json Outdated
| "php-http/client-implementation": "^1.0" | ||
| | ||
| "php-http/client-implementation": "^1.0", | ||
| "php-http/message-implementation": "^1.0", |
There was a problem hiding this comment.
This should be psr/http-message-implementation
| | ||
| "php-http/client-implementation": "^1.0", | ||
| "php-http/message-implementation": "^1.0", | ||
| "php-http/message-factory-implementation": "^1.0" |
There was a problem hiding this comment.
Hum, looks like it does now ? https://packagist.org/providers/php-http/message-factory-implementation
But that's strange, as there is nothing on the php-http/message repo that says that it implements this virtual package, unless I read it wrong ?
There was a problem hiding this comment.
It is not merged yet: php-http/message#80
NEED MOAR PACKAGES FROM PHP-HTTP !!
Taluu force-pushed the implementations-details branch from 7d3427a to 4a4bf24 Compare Taluu force-pushed the implementations-details branch from 4a4bf24 to 26d492f Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
NEED MOAR PACKAGES FROM PHP-HTTP !!