Skip to content

Commit f373d22

Browse files
author
jantje
committed
Param name states name but it is a ID
1 parent 18e0ad1 commit f373d22

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

io.sloeber.core/src/io/sloeber/core/api/BoardsManager.java

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ public class BoardsManager {
9494
* if jsonFileName equals "local" the filename of the boards.txt
9595
* containing the boards. otherwise the name of the package
9696
* containing the board
97-
* @param architectureName
97+
* @param architectureID
9898
* ignored if jsonFileName equals "local" otherwise the architecture
9999
* name of the platform containing the board (this assumes the
100100
* architecture is the unique id for the platform)
@@ -105,26 +105,25 @@ public class BoardsManager {
105105
* file) or null for defaults
106106
* @return The class BoardDescriptor or null
107107
*/
108-
static public BoardDescription getBoardDescription(String jsonFileName, String packageName, String architectureName,
108+
static public BoardDescription getBoardDescription(String jsonFileName, String packageName, String architectureID,
109109
String boardID, Map<String, String> options) {
110110
if (LOCAL.equals(jsonFileName)) {
111111
return new BoardDescription(new File(packageName), boardID, options);
112112
}
113-
return getNewestBoardIDFromBoardsManager(jsonFileName, packageName, architectureName, boardID, options);
113+
return getNewestBoardIDFromBoardsManager(jsonFileName, packageName, architectureID, boardID, options);
114114
}
115115

116116
static private BoardDescription getNewestBoardIDFromBoardsManager(String jsonFileName, String packageName,
117-
String architectureName, String boardID, Map<String, String> options) {
117+
String architectureID, String boardID, Map<String, String> options) {
118118

119119
ArduinoPackage thePackage = getPackage(jsonFileName, packageName);
120120
if (thePackage == null) {
121-
// fail("failed to find package:" + this.mPackageName);
121+
System.err.println("failed to find package:" + packageName); //$NON-NLS-1$
122122
return null;
123123
}
124-
ArduinoPlatform platform = thePackage.getPlatform(architectureName);
124+
ArduinoPlatform platform = thePackage.getPlatform(architectureID);
125125
if (platform == null) {
126-
// fail("failed to find platform " + this.mPlatform + " in
127-
// package:" + this.mPackageName);
126+
System.err.println("failed to find architecture ID " + architectureID + " in package:" + packageName); //$NON-NLS-1$ //$NON-NLS-2$
128127
return null;
129128
}
130129
ArduinoPlatformVersion platformVersion = platform.getNewestVersion();

0 commit comments

Comments
 (0)