Merge branch 'patch/header-testing'

Author: SidOfc

lib/browserino/definitions/missing_props.rb

@@ -13,7 +13,7 @@
  prop_missing :locales do |http_headers|
  http_headers[:accept_language]
  .to_s.scan(/(\w{2}(?:[_\-]\w{2})?)(?:;q=([\d.]+))?/i)
- .map { |(locale, quality)| [locale, (quality || 1).to_i] }
+ .map { |(locale, quality)| [locale, (quality || 1).to_f] }
  .sort_by { |a| -a[1] }
  .map(&:first)
  end

spec/missing_props_spec.rb

@@ -0,0 +1,43 @@
+require 'spec_helper'
+
+describe 'Browserino' do
+ describe 'http header fallback' do
+ it 'normalizes raw header names' do
+ plain_headers = Browserino.normalize_header_keys({'Accept-Language' => 'en-US,en;q=0.9,nl-NL;q=0.8,nl;q=0.7'})
+
+ expect(plain_headers.key?(:accept_language)).to be_truthy
+ end
+
+ it 'normalizes Rails header names' do
+ rails_headers = Browserino.normalize_header_keys({'HTTP_ACCEPT_LANGUAGE' => 'en-US,en;q=0.9,nl-NL;q=0.8,nl;q=0.7'})
+
+ expect(rails_headers.key?(:accept_language)).to be_truthy
+ end
+
+ it 'sorts HTTP_ACCEPT_LANGUAGE locales by quality' do
+ client = Browserino.parse(
+ 'Mozilla/5.0 (Linux; Android 5.1; ZTE Blade L6 Build/LMY47I) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.91 Mobile Safari/537.36',
+ {'HTTP_ACCEPT_LANGUAGE' => 'en-US,en;q=0.9,nl-NL;q=0.6,nl;q=0.7'}
+ )
+
+ expect(client.locales).to eq %i[en_us en nl nl_nl]
+ end
+
+ it 'can detect language from Accept-Language header when headers given' do
+ client = Browserino.parse(
+ 'Mozilla/5.0 (Linux; Android 5.1; ZTE Blade L6 Build/LMY47I) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.91 Mobile Safari/537.36',
+ {'HTTP_ACCEPT_LANGUAGE' => 'en-US,en;q=0.9,nl-NL;q=0.8,nl;q=0.7'}
+ )
+
+ expect(client.locale).to eq :en_us
+ expect(client.locales).to eq %i[en_us en nl_nl nl]
+ end
+
+ it 'cannot detect language from Accept-Language header when no headers given' do
+ client = Browserino.parse 'Mozilla/5.0 (Linux; Android 5.1; ZTE Blade L6 Build/LMY47I) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.91 Mobile Safari/537.36'
+
+ expect(client.locale).to be_nil
+ expect(client.locales).to eq %i[]
+ end
+ end
+end