Add isort to pre-commit (appium#379)

* Add isort to pre-commit * Add isort.conf * Applied isort for test/unit * Add current dir to isrot arg * Add check to ci.sh * Use exit code for condition check in ci.sh

Author: ki4070ma

.isort.cfg

@@ -0,0 +1,3 @@
+[settings]
+multi_line_output = 3
+known_third_party = dateutil,httpretty,pytest,selenium,setuptools,urllib3

.pre-commit-config.yaml

@@ -3,3 +3,8 @@
  hooks:
  - id: autopep8
  args: ["--global-config", ".config-pep8", "-i"]
+- repo: https://github.com/pre-commit/mirrors-isort
+ rev: v4.3.20
+ hooks:
+ - id: isort
+ args: ["-rc", "."]

README.md

@@ -44,6 +44,10 @@ download and unarchive the source tarball (Appium-Python-Client-X.X.tar.gz).
  ```
  $ python -m autopep8 -r --global-config .config-pep8 -i .
  ```
+ - `isort` helps to order imports automatically
+ ```
+ $ python -m isort -rc .
+ ```
 - You can customise `CHANGELOG.rst` with commit messages following [.gitchangelog.rc](.gitchangelog.rc)
  - It generates readable changelog
 - Setup

appium/saucetestcase.py

@@ -16,9 +16,10 @@
 
 from __future__ import print_function
 
-import unittest
 import os
 import sys
+import unittest
+
 from appium import webdriver
 from sauceclient import SauceClient
 

appium/webdriver/appium_service.py

@@ -17,6 +17,7 @@
 import subprocess
 import sys
 import time
+
 import urllib3
 
 DEFAULT_HOST = '127.0.0.1'

appium/webdriver/errorhandler.py

@@ -12,8 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from selenium.webdriver.remote import errorhandler
 from selenium.common.exceptions import WebDriverException
+from selenium.webdriver.remote import errorhandler
 
 from appium.common.exceptions import NoSuchContextException
 

appium/webdriver/extensions/android/activities.py

@@ -15,6 +15,7 @@
 from selenium import webdriver
 from selenium.common.exceptions import TimeoutException
 from selenium.webdriver.support.ui import WebDriverWait
+
 from appium.webdriver.mobilecommand import MobileCommand as Command
 
 

appium/webdriver/extensions/android/gsm.py

@@ -13,10 +13,10 @@
 # limitations under the License.
 
 from selenium import webdriver
-from appium.webdriver.mobilecommand import MobileCommand as Command
 
-from appium.common.logger import logger
 from appium.common.helper import extract_const_attributes
+from appium.common.logger import logger
+from appium.webdriver.mobilecommand import MobileCommand as Command
 
 
 class GsmCallActions(object):

appium/webdriver/extensions/android/network.py

@@ -13,6 +13,7 @@
 # limitations under the License.
 
 from selenium import webdriver
+
 from appium.webdriver.mobilecommand import MobileCommand as Command
 
 

appium/webdriver/extensions/android/performance.py

@@ -13,6 +13,7 @@
 # limitations under the License.
 
 from selenium import webdriver
+
 from appium.webdriver.mobilecommand import MobileCommand as Command