NotificationGroupValue to use rawurlencode on a group link

Author: mwjames

docs/01-workflow.md

@@ -4,14 +4,12 @@
 ![image](https://cloud.githubusercontent.com/assets/1245473/16138621/cd46a8ba-343f-11e6-870f-9ddb92f29d07.png)
 
 To receive notifications, a user has to enable the specific Semantic MediaWiki
-related notification [preferences][pref].
-
-An agent (the user that initiated a change) is generally excluded from receiving notifications
-about his own actions.
+related notification [preferences][pref] with an agent (the user that initiated a change) being
+generally excluded from receiving notifications about his own actions.
 
 ## Workflow
 
-![image](https://cloud.githubusercontent.com/assets/1245473/16158621/45c766c0-34be-11e6-97fc-e22d87df9441.png)
+![image](https://cloud.githubusercontent.com/assets/1245473/18805668/7cb694a0-8214-11e6-952d-e84e98fa6899.png)
 
 ### Monitor value changes
 

i18n/en.json

@@ -5,7 +5,7 @@
 ]
 },
 "smw-notifications-desc": "A Semantic MediaWiki extension that notifies about changes to structured data using the Echo(Notifications) extension.",
-"smw-notifications-enity-specification-change-group": "entity specification change group",
+"smw-notifications-entity-specification-change-group": "entity specification change group",
 
 "echo-category-title-smw-value-change": "Entity value change (SMW)",
 "echo-pref-tooltip-smw-value-change": "Notify me when a change to a selected entity (property, category) value in Semantic MediaWiki occurs.",

i18n/qqq.json

@@ -5,5 +5,6 @@
 "Kghbln"
 ]
 },
-"smw-scribunto-desc": "{{desc|name=Semantic Scribunto|url=https://www.mediawiki.org/wiki/Extension:Semantic_Scribunto}}"
+"smw-notifications-desc": "{{desc|name=Semantic Notifications|url=https://www.mediawiki.org/wiki/Extension:Semantic_Notifications}}",
+"smw-notifications-entity-specification-change-group": "Canonical name of the specification group"
 }

src/DataValues/NotificationGroupValue.php

@@ -22,7 +22,7 @@
  */
 class NotificationGroupValue extends StringValue {
 
-const SPECIAL_GROUP = 'smw-notifications-enity-specification-change-group';
+const SPECIAL_GROUP = 'smw-notifications-entity-specification-change-group';
 
 /**
  * Get name in a possible localized representation
@@ -50,15 +50,15 @@ protected function parseUserValue( $value ) {
 }
 
 if ( !$this->isKnownNotificationsGroup( $inputValue ) ) {
-$this->addErrorMsg( array( 'smw-notifications-datavalue-invalid-group', $inputValue ) );
+$this->addErrorMsg( array( 'smw-notifications-datavalue-invalid-group', $inputValue ), Message::PARSE );
 $this->m_dataitem = new DIBlob( 'ERROR' );
 return;
 }
 
 // If it has no contextPage it is most likely linked from a Special page
 // such as Special:SearchByProperty or Special:Ask
 if ( $this->getContextPage() !== null && !$this->hasUserContext() ) {
-$this->addErrorMsg( array( 'smw-notifications-datavalue-restricted-to-user', $inputValue ) );
+$this->addErrorMsg( array( 'smw-notifications-datavalue-restricted-to-user', $inputValue ), Message::PARSE );
 $this->m_dataitem = new DIBlob( 'ERROR' );
 return;
 }
@@ -92,7 +92,7 @@ public function getShortWikiText( $linker = null ) {
 $text = SpecialPage::getTitleFor( 'SearchByProperty' )->getPrefixedText();
 
 // This is a bit heavy handed ...
-return '[[' . $text . '/' . SMW_NOTIFICATIONS_TO_GROUP . '/' . urlencode( $this->m_caption ) . '|' . $this->m_caption . ']]';
+return '[[' . $text . '/' . SMW_NOTIFICATIONS_TO_GROUP . '/' . rawurlencode( $this->m_caption ) . '|' . $this->m_caption . ']]';
 }
 
 /**

tests/phpunit/Unit/DataValues/NotificationGroupValueTest.php

@@ -157,26 +157,26 @@ public function testSetUserValueWithValidUserContextAndNotNullLinker() {
 DIWikiPage::newFromText( __METHOD__, NS_USER )
 );
 
-$instance->setUserValue( 'Foo' );
+$instance->setUserValue( 'Foo bar' );
 $instance->setCaption( false );
 
 $this->assertContains(
-SMW_NOTIFICATIONS_TO_GROUP . '/' . 'Foo',
+SMW_NOTIFICATIONS_TO_GROUP . '/' . 'Foo%20bar',
 $instance->getShortWikiText( '' )
 );
 
 $this->assertContains(
-SMW_NOTIFICATIONS_TO_GROUP . '/' . 'Foo',
+SMW_NOTIFICATIONS_TO_GROUP . '/' . 'Foo%20bar',
 $instance->getLongWikiText( '' )
 );
 
 $this->assertContains(
-'value=Foo',
+'value=Foo+bar',
 $instance->getShortHTMLText( '' )
 );
 
 $this->assertContains(
-'value=Foo',
+'value=Foo+bar',
 $instance->getLongHTMLText( '' )
 );
 }