Skip to content

Commit d3ecb07

Browse files
committed
[grid] Dynamic Grid is able to disable video container spawn up
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
1 parent 45a6759 commit d3ecb07

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

java/src/org/openqa/selenium/grid/node/docker/DockerOptions.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public class DockerOptions {
6161
static final String DOCKER_SECTION = "docker";
6262
static final String DEFAULT_ASSETS_PATH = "/opt/selenium/assets";
6363
static final String DEFAULT_DOCKER_URL = "unix:/var/run/docker.sock";
64-
static final String DEFAULT_VIDEO_IMAGE = "selenium/video:latest";
64+
static final String DEFAULT_VIDEO_IMAGE = "false";
6565
static final int DEFAULT_MAX_SESSIONS = Runtime.getRuntime().availableProcessors();
6666
private static final String DEFAULT_DOCKER_NETWORK = "bridge";
6767
private static final Logger LOG = Logger.getLogger(DockerOptions.class.getName());

java/src/org/openqa/selenium/grid/node/docker/DockerSessionFactory.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -286,16 +286,15 @@ private Capabilities addForwardCdpEndpoint(
286286
}
287287

288288
private Container createBrowserContainer(int port, Capabilities sessionCapabilities) {
289-
Map<String, String> browserContainerEnvVars = getBrowserContainerEnvVars(sessionCapabilities);
289+
Map<String, String> browserContainerEnvVars = new HashMap<>();
290290
// Enable env var to trigger video recording if session capabilities request and external video
291291
// container is disabled
292292
if (videoImage == null && recordVideoForSession(sessionCapabilities)) {
293293
browserContainerEnvVars.put("SE_RECORD_VIDEO", "true");
294294
browserContainerEnvVars.put("SE_VIDEO_FILE_NAME", "auto");
295-
if (runningInDocker) {
296-
browserContainerEnvVars.put("SE_VIDEO_RECORD_STANDALONE", "true");
297-
}
295+
browserContainerEnvVars.put("SE_VIDEO_RECORD_STANDALONE", "true");
298296
}
297+
browserContainerEnvVars.putAll(getBrowserContainerEnvVars(sessionCapabilities));
299298
long browserContainerShmMemorySize = 2147483648L; // 2GB
300299
ContainerConfig containerConfig =
301300
image(browserImage)

0 commit comments

Comments
 (0)