Skip to content

Commit a04a22f

Browse files
committed
[java] Ack the log file argument without need to combine it
Fixes #12225
1 parent 235bc94 commit a04a22f

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

java/src/org/openqa/selenium/chrome/ChromeDriverService.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,7 @@ protected List<String> createArgs() {
378378

379379
// Readable timestamp and append logs only work if a file is specified
380380
// Can only get readable logs via arguments; otherwise send service output as directed
381-
if (getLogFile() != null && (readableTimestamp || appendLog)) {
381+
if (getLogFile() != null) {
382382
args.add(String.format("--log-path=%s", getLogFile().getAbsolutePath()));
383383
if (readableTimestamp != null && readableTimestamp.equals(Boolean.TRUE)) {
384384
args.add("--readable-timestamp");
@@ -392,12 +392,6 @@ protected List<String> createArgs() {
392392
if (logLevel != null) {
393393
args.add(String.format("--log-level=%s", logLevel.toString().toUpperCase()));
394394
}
395-
// if (silent != null && silent.equals(Boolean.TRUE)) {
396-
// args.add("--silent");
397-
// }
398-
// if (verbose != null && verbose.equals(Boolean.TRUE)) {
399-
// args.add("--verbose");
400-
// }
401395
if (allowedListIps != null) {
402396
args.add(String.format("--allowed-ips=%s", allowedListIps));
403397
}

java/src/org/openqa/selenium/edge/EdgeDriverService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ protected List<String> createArgs() {
314314

315315
// Readable timestamp and append logs only work if a file is specified
316316
// Can only get readable logs via arguments; otherwise send service output as directed
317-
if (getLogFile() != null && (readableTimestamp || appendLog)) {
317+
if (getLogFile() != null) {
318318
args.add(String.format("--log-path=%s", getLogFile().getAbsolutePath()));
319319
if (readableTimestamp != null && readableTimestamp.equals(Boolean.TRUE)) {
320320
args.add("--readable-timestamp");

0 commit comments

Comments
 (0)