Skip to content

Change the implementation of indicator by using view modifier #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Change the implementation of indicator by using view modifier #33

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6a6d58
Use View Modifier instead of new view type for indicator, simplify th…
dreampiggy Oct 28, 2019
14bb4be
The progress indicator bar style is only available on iOS
dreampiggy Oct 28, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
The progress indicator bar style is only available on iOS
  • Loading branch information
@dreampiggy
dreampiggy committed Oct 28, 2019
commit 14bb4be6a8fb5b2b367a46b4151acadae4064877
4 changes: 3 additions & 1 deletion SDWebImageSwiftUI/Classes/Indicator/ProgressIndicator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public struct ProgressIndicator: PlatformViewRepresentable {
case .bar:
progressStyle = .bar
#endif
default:
case .default:
progressStyle = .default
}
let uiView = ProgressIndicatorWrapper()
Expand Down Expand Up @@ -99,7 +99,9 @@ public struct ProgressIndicator: PlatformViewRepresentable {
extension ProgressIndicator {
public enum Style {
case `default`
#if os(iOS)
case bar
#endif
}
}
#endif