Skip to content

Commit 6f2c34e

Browse files
authored
&1 attributes reach threshold of &2 (#168)
* %261 reach threshold of %262 * reach => reaching * minor fixes
1 parent afa5944 commit 6f2c34e

7 files changed

+10
-8
lines changed

src/checks/y_check_num_exec_statements.clas.abap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ CLASS Y_CHECK_NUM_EXEC_STATEMENTS IMPLEMENTATION.
5252

5353
add_obj_type( c_type_program ).
5454

55-
set_check_message( '&1 executable statements in method, exceeds threshold &2' ).
55+
set_check_message( '&1 executable statements in method reaching threshold of &2' ).
5656
ENDMETHOD.
5757

5858

src/checks/y_check_num_output_parameter.clas.abap

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ CLASS Y_CHECK_NUM_OUTPUT_PARAMETER IMPLEMENTATION.
2121
settings-threshold = 2.
2222
settings-documentation = |{ c_docs_path-checks }number-output-parameter.md|.
2323

24-
set_check_message( 'Too many output parameters!' ).
24+
set_check_message( '&1 output parameters reaching threshold of &2' ).
2525
ENDMETHOD.
2626

2727

@@ -67,7 +67,9 @@ CLASS Y_CHECK_NUM_OUTPUT_PARAMETER IMPLEMENTATION.
6767
raise_error( statement_level = statement-level
6868
statement_index = index
6969
statement_from = statement-from + 1
70-
error_priority = configuration-prio ).
70+
error_priority = configuration-prio
71+
parameter_01 = |{ outputs_of_statement }|
72+
parameter_02 = |{ configuration-threshold }| ).
7173

7274
ENDMETHOD.
7375

src/checks/y_check_num_public_attributes.clas.abap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ CLASS Y_CHECK_NUM_PUBLIC_ATTRIBUTES IMPLEMENTATION.
8383
settings-threshold = 1.
8484
settings-documentation = |{ c_docs_path-checks }number-public-attributes.md|.
8585

86-
set_check_message( '&1 public attributes. All attributes should be private by default.' ).
86+
set_check_message( '&1 public attributes. All attributes should be private/protected by default.' ).
8787
ENDMETHOD.
8888

8989

src/checks/y_check_number_attributes.clas.abap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ CLASS Y_CHECK_NUMBER_ATTRIBUTES IMPLEMENTATION.
7777
settings-threshold = 12.
7878
settings-documentation = |{ c_docs_path-checks }number-attributes.md|.
7979

80-
set_check_message( '&1 attributes, exceeding threshold &2' ).
80+
set_check_message( '&1 attributes reaching threshold of &2' ).
8181
ENDMETHOD.
8282

8383

src/checks/y_check_number_events.clas.abap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ CLASS Y_CHECK_NUMBER_EVENTS IMPLEMENTATION.
4545
settings-pseudo_comment = '"#EC NUMBER_EVENTS' ##NO_TEXT.
4646
settings-documentation = |{ c_docs_path-checks }number-events.md|.
4747

48-
set_check_message( 'There are &1 events, exceeding threshold of &2' ).
48+
set_check_message( '&1 events reaching threshold of &2' ).
4949
ENDMETHOD.
5050

5151

src/checks/y_check_number_interfaces.clas.abap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ CLASS Y_CHECK_NUMBER_INTERFACES IMPLEMENTATION.
4747
settings-threshold = 4.
4848
settings-documentation = |{ c_docs_path-checks }number-interfaces.md|.
4949

50-
set_check_message( 'There are &1 interfaces, exceeding threshold of &2' ).
50+
set_check_message( '&1 interfaces reaching threshold of &2' ).
5151
ENDMETHOD.
5252

5353

src/checks/y_check_number_methods.clas.abap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ CLASS Y_CHECK_NUMBER_METHODS IMPLEMENTATION.
4949
settings-threshold = 20.
5050
settings-documentation = |{ c_docs_path-checks }number-methods.md|.
5151

52-
set_check_message( '&1 methods, exceeding threshold of &2' ).
52+
set_check_message( '&1 methods reaching threshold of &2' ).
5353
ENDMETHOD.
5454

5555

0 commit comments

Comments
 (0)