Update configurations for the project #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
• Remove redundancy in the .gitignore regarding Carthage. • Update the dependencies in the Cartfile & Podfile • Update DemoTest to Swift 4 updating the project settings and removing warnings. • Replace the deprecated `addDisposableTo(_:)` in favor of `disposed(by:)`.
Member Author
| Not sure about the current structure of the Current master |
Member
| @Vkt0r you should replace the |
Member Author
| @ashfurrow Thanks 👍. Done !! |
ashfurrow reviewed Mar 22, 2018
Member
ashfurrow left a comment
ashfurrow left a comment There was a problem hiding this comment.
Looks good, just one question.
Demo/Demo/AppDelegate.swift Outdated
| | ||
| | ||
| func application(application: UIApplication, didFinishLaunchingWithOptions launchOptions: [NSObject: AnyObject]?) -> Bool { | ||
| private func application(application: UIApplication, didFinishLaunchingWithOptions launchOptions: [NSObject: AnyObject]?) -> Bool { |
Member Author
| @ashfurrow 😅 Good catch!!, no idea where that was coming. It was XCode with the fix warnings, crazy. |
ashfurrow approved these changes Mar 22, 2018
Member
| I released this as 4.3.0, it should be available through Carthage and CocoaPods. Thanks again! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi guys,
Just a small changes in code. Big changes nevertheless updating the Pods.
CHANGES:
• Remove redundancy in the .gitignore regarding Carthage.
• Update the dependencies in the Cartfile & Podfile
• Update DemoTest to Swift 4 updating the project settings and removing warnings.
• Replace the deprecated
addDisposableTo(_:)in favor ofdisposed(by:)in the DemoTest.